CNX-9912 - Implement a display fallback for Revit Areas equivalent to the outline. #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to retrieve or generate a displayMesh
JR-Morgan
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Looks to be some build failures in other connectors (tekla) introduced by this PR. I'd assume there's a couple places where we're consuming this displayValue list directly.
Let me know if you need a hand @jsdbroughton
Inflicted by the same error as AdvanceSteel
Tekla ContourPlates were also inherited from Area - this could be where AdvanceSteel was inspired |
JR-Morgan
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
displayValueto be the Area outline as there is no method to retrieve or generate aMesh