QGIS attributes in Revit #3595
Merged
QGIS attributes in Revit #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BovineOx
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
It feels broadly okay but it does introduce tight coupling between GIS and Revit. I suggest you can @clairekuang agree this makes sense and socailise with @didimitrie also but happy to approve. If it's an a deeper issue then we can always back this out.
| var traversal = new GraphTraversal(DefaultTraversal.DefaultRule); | ||
| var meshes = traversal.Traverse(gisFeature).Select(tc => tc.current).Where(b => b is Mesh); | ||
|
|
||
| speckleDirectShape.baseGeometries.AddRange(meshes); |
There was a problem hiding this comment.
Is it okay if meshes is empty? could meshes be empty?
| @@ -11,6 +11,34 @@ namespace Objects.Converter.Revit; | |||
|
|
|||
| public partial class ConverterRevit | |||
| { | |||
| public ApplicationObject GisFeatureToNative(GisFeature gisFeature) | |||
There was a problem hiding this comment.
This is creating a tight coupling between Gis and Revit, are we happy for this? We did discuss that we need to be careful when picking support for these workflows. I guess we've done it for other things but might be worth discussing with @clairekuang as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicating attribute receive functionality from GisPolygon to GisFeature