Fix: Throw SpeckleException on unhandled elements #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther than nulling object refs (which throws an exception terminating the receive)
JR-Morgan
requested changes
Jul 29, 2024
There was a problem hiding this comment.
CI is failing because of formatting violations: https://app.circleci.com/pipelines/github/specklesystems/speckle-sharp/16133/workflows/83fb3eb9-0431-4634-ab54-3916cadb82ab/jobs/150626
Please run dotnet csharpier . in the command line, it should reformat the offending file
JR-Morgan
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Change handling of non-polyline openings to throw SpeckleException rather than nulling object refs (which throws an exception terminating the receive)