Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit Connector: Floors missing when converting linked models #3635

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

ks-cph
Copy link
Contributor

@ks-cph ks-cph commented Oct 1, 2024

Description & motivation

Refers to #3634
-->

Changes:

The Document is not the linked document.

To-do before merge:

Screenshots:

Validation of changes:

Tested with three projects.

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@JR-Morgan JR-Morgan self-requested a review October 15, 2024 10:38
@JR-Morgan JR-Morgan changed the base branch from dev to main October 15, 2024 10:38
@JR-Morgan JR-Morgan merged commit 052aa15 into specklesystems:main Oct 15, 2024
31 checks passed
@JR-Morgan
Copy link
Member

Good catch @ks-cph, we should definitely be using the element.Document over Doc for all ToSpeckle conversions.

We'll be pushing a hotfix shortly with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RevitConnector: Floors from linked Revit model not converted
4 participants