Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNX-599 - ETABS Sending Multiple Load Combination Results #3636

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

bjoernsteinhagen
Copy link
Contributor

@bjoernsteinhagen bjoernsteinhagen commented Oct 1, 2024

Description & motivation

  • When sending results from ETABS, irrespective of how many load cases / combinations are set to send, only the first load combination of the list gets sent.
  • This is due to the loadCasesCommaSeparated having a leading white space for entries after the first entry in the array.

Changes:

  • Applying a fix TrimStart()
  • Leading white space only in the event that the user string for load combinations have a trailing white space

string[] loadCases = loadCasesCommaSeparated.Split(',').Select(s => s.TrimStart()).ToArray();

Validation of changes:

  • Settings for sending multiple load combinations
image
  • What initally got received (only the first combination):
image
  • After changes:
image

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

@bjoernsteinhagen bjoernsteinhagen added enhancement New feature or request CSI labels Oct 1, 2024
@bjoernsteinhagen bjoernsteinhagen self-assigned this Oct 1, 2024
Copy link

linear bot commented Oct 1, 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadCasesCommaSeparated has leading white spaces for all entries after the first loadCase

@JR-Morgan JR-Morgan self-requested a review October 15, 2024 10:45
@JR-Morgan JR-Morgan changed the base branch from dev to main October 15, 2024 10:46
@JR-Morgan JR-Morgan merged commit fa2d92e into main Oct 15, 2024
32 checks passed
@JR-Morgan JR-Morgan deleted the bjorn/cnx-599-etabs-sending-results branch October 15, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants