Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workspace Id tracking #3637

Merged

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Oct 7, 2024

This PR adds workspace_id tracking for Receive and Send events.


I was going to add support for fetching the workspace id to all of the ProjectResource queries, like I've done for the v3 sdk specklesystems/speckle-sharp-sdk#134

But, since its important that the v2 SDK is compatible with older self hosted servers, I thought it would be easiest simply to
add a helper function just for this query. This avoids having to add a version check in each of the Project resources (which, at least right now in their current form don't have direct access to the underlying GqlClient.


Needs through testing:

  • Test with app.speckle.systems:

    • project on a workspace, does it track send and receives in mixpanel
    • project not on a workspace, should track null
  • Test with testing1

    • project not on a workspace, should track null, nothing should throw!

Copy link

linear bot commented Oct 7, 2024

@JR-Morgan JR-Morgan marked this pull request as ready for review October 14, 2024 11:48
@JR-Morgan JR-Morgan requested a review from didimitrie October 14, 2024 11:52
@didimitrie
Copy link
Member

note: didn't test locally, just sanity check glanced at the code!

@JR-Morgan JR-Morgan requested a review from AlanRynne October 15, 2024 10:32
@AlanRynne AlanRynne merged commit 0230748 into main Oct 15, 2024
32 checks passed
@AlanRynne AlanRynne deleted the jedd/cxpla-96-update-sdks-to-add-new-workspaces-properties branch October 15, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants