Jrm/branch get nullability #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elected object. (#3651) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things
… duplicate (#3652) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * First becomes Last
* Updated DUI2 * remove comment subscription * Comments * fix comment * VersionUpdate subscription workaround * Dynamo * Fixed issue with collections being modified while enumerating * removed deprecated tests * Marked deprecated true on all legacy subscriptions * using directives
Remove keyboard shortcuts from plugin registration
For POC purposes - implements a fix - needs investigation
* Ensure CI runs on net8 * remove net 7 * bump csharpier for net8 support * ensure net8 sdk is available on connector builds * relax rollforward rules instead
Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
* File Added: ConvertStructuralMaterial Separated methods pertaining to StructuralMaterial outside of the ConvertAnalyticalStick.cs file. Didn't make sense that these functions were in the ConvertAnalyticalStick.cs when the ConvertAnalyticalSurface.cs referenced them * ScaleToSpeckle Material properties were sent as revit internal units. Inconsistent with the Revit model / project units. These can't be used for connection applications (e.g. receiving analytical elements in ETABS) * ETABS Receive Property2D ETABS currently only created properties for Element2Ds with a CSIProperty2D, but what about Property2D? These should also be received without us defaulting to the "Slab1" ETABS section. * ETABS Receive Wall Property Walls were previously assigned with slab sections which is incorrect. The WallPropertyToNative() was implemented (previously raised a ConversionNotSupportedException for some reason) * RVT 22 Scaling Updates Testing on Revit 2022 - ETABS connection * Default Fallback Assign at least something to Element2D * Fixed shared project case sensitivity * IDE0005 --------- Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
* ping should ping a static asset and add user agent headers * fix: fmt * Removed frontend headers check for FE1 servers * Removed another test that relied on this pinging --------- Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com> Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
Removed tracking for grasshopper node runs
* Optimised large queries * fix mistake
* Optimised large queries * fix mistake * fix another mistake
* fix: Dissapearing components after save SyncReceive would disappear upon opening a document (or while saving) due to exceptions being thrown in the Read/Write logic, which shouldn't ever throw. * fix: Write method for Kit name is unnecessary, dealt with in parent class
Do not assume internal storage `m_value` will exist in all GH_Goo's, some have varying implementation, but `Value` is usually consistent on all pre-rhino8 GH types
jsdbroughton
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed regression with branch get not handling null return when branch does not exist