Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection Prompt Search #1289

Merged
merged 17 commits into from
Feb 25, 2024

Conversation

slang25
Copy link
Contributor

@slang25 slang25 commented Sep 3, 2023

Multi Selection Search

This PR adds a couple of features to Selection Prompt:

  • Search as you type
  • Skipping selection of group nodes for Leaf selection mode

I've yet to add the tests which is a bit naughty, but wanted to share what I have so far to start some discussion. Is this feature welcome, or is there a better direction?

@slang25 slang25 force-pushed the selection-prompt-search branch 3 times, most recently from 27d4efd to 99392f8 Compare September 3, 2023 18:42
@slang25
Copy link
Contributor Author

slang25 commented Sep 3, 2023

This is somewhat related to #1258, as this is a feature I'd really like in my CLI, however my only feasible options are to fork the library or hope I can get this merged.

@slang25 slang25 marked this pull request as ready for review September 4, 2023 12:28
@slang25 slang25 changed the title Multi Selection Search Selection Prompt Search Sep 4, 2023
@GOATS2K
Copy link

GOATS2K commented Sep 14, 2023

This looks incredibly helpful - I'd love to see this merged soon.

@slang25
Copy link
Contributor Author

slang25 commented Sep 15, 2023

Thanks @GOATS2K, I'm pretty happy with it and am using it in one of my apps. I've just updated the API names to be a bit more sensible.

@patriksvensson what are your thoughts on this?

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think some minor things need to be addressed. I would also like to see some tests for the search functionality.

src/Spectre.Console/Prompts/SelectionPromptExtensions.cs Outdated Show resolved Hide resolved
src/Spectre.Console/Prompts/List/IListPromptStrategy.cs Outdated Show resolved Hide resolved
src/Spectre.Console/Prompts/SelectionPrompt.cs Outdated Show resolved Hide resolved
@slang25
Copy link
Contributor Author

slang25 commented Sep 24, 2023

@patriksvensson thanks for taking a look, I've addressed the feedback. I've added some tests, I could add some Verify tests too and cover more scenarios but am on the fence, let me know what you think.

Copy link

@sleepyfran sleepyfran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, really excited to use it! I took it for a spin in a personal fork and found the issue I commented about. Other than that it seems to work perfectly 🙇🏻

src/Spectre.Console/Prompts/SelectionPrompt.cs Outdated Show resolved Hide resolved
@slang25
Copy link
Contributor Author

slang25 commented Feb 23, 2024

Hi @patriksvensson, please could you take another look at this PR when you get some time. I'm happy to address any further feedback 🙂

@Jacob-32587
Copy link

Would love to see this go through soon, extremely useful feature when dealing with large prompts.

@patriksvensson
Copy link
Contributor

@slang25 I'm rebasing this and fixing the merge conflicts right now

@patriksvensson patriksvensson merged commit 397b742 into spectreconsole:main Feb 25, 2024
3 checks passed
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

@slang25
Copy link
Contributor Author

slang25 commented Feb 25, 2024

Thanks @patriksvensson, this library is such a gem for the .NET community, I hope you have time to keep it going 🙂 I was worried we'd lose you to swift 😅

@patriksvensson
Copy link
Contributor

@slang25 Haha, thanks! I still have a lot of love for dotnet 🙂

renovate bot referenced this pull request in buehler/dotnet-operator-sdk Apr 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[Spectre.Console.Testing](https://github.com/spectreconsole/spectre.console)
| `0.48.0` -> `0.49.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>spectreconsole/spectre.console
(Spectre.Console.Testing)</summary>

###
[`v0.49.0`](https://github.com/spectreconsole/spectre.console/releases/tag/0.49.0)

[Compare
Source](https://github.com/spectreconsole/spectre.console/compare/0.48.0...0.49.0)

##### What's Changed

- Cleanup Line-Endings by [@&#8203;nils-a](https://github.com/nils-a)
in
[https://github.com/spectreconsole/spectre.console/pull/1381](https://github.com/spectreconsole/spectre.console/pull/1381)
- Added spectre.console.cli to quick-start. by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1413](https://github.com/spectreconsole/spectre.console/pull/1413)
- Fix rendering of ListPrompt for odd pageSizes by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1365](https://github.com/spectreconsole/spectre.console/pull/1365)
- Remove mandelbrot example due to conflicting license by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1426](https://github.com/spectreconsole/spectre.console/pull/1426)
- Allow specifying a property to ignore the use of build-time packages
for versioning and analysis by
[@&#8203;baronfel](https://github.com/baronfel) in
[https://github.com/spectreconsole/spectre.console/pull/1425](https://github.com/spectreconsole/spectre.console/pull/1425)
- Add the possibility to register multiple interceptors by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1412](https://github.com/spectreconsole/spectre.console/pull/1412)
- Added the ITypeResolver to the ExceptionHandler by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1411](https://github.com/spectreconsole/spectre.console/pull/1411)
- Updated typo in commandApp.md by
[@&#8203;DarqueWarrior](https://github.com/DarqueWarrior) in
[https://github.com/spectreconsole/spectre.console/pull/1431](https://github.com/spectreconsole/spectre.console/pull/1431)
- Command with -v displays app version instead of executing the command
by [@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1427](https://github.com/spectreconsole/spectre.console/pull/1427)
- HelpProvider colors should be configurable by
[@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1408](https://github.com/spectreconsole/spectre.console/pull/1408)
- Direct contributors to the current CONTRIBUTING.md by
[@&#8203;tonycknight](https://github.com/tonycknight) in
[https://github.com/spectreconsole/spectre.console/pull/1435](https://github.com/spectreconsole/spectre.console/pull/1435)
- Fix deadlock when cancelling prompts by
[@&#8203;caesay](https://github.com/caesay) in
[https://github.com/spectreconsole/spectre.console/pull/1439](https://github.com/spectreconsole/spectre.console/pull/1439)
- Add progress bar value formatter by
[@&#8203;jsheely](https://github.com/jsheely) in
[https://github.com/spectreconsole/spectre.console/pull/1414](https://github.com/spectreconsole/spectre.console/pull/1414)
- Update dependencies and do some clean-up by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1440](https://github.com/spectreconsole/spectre.console/pull/1440)
- Delete \[UsesVerify], which has become obsolete through the latest
update. by [@&#8203;danielcweber](https://github.com/danielcweber) in
[https://github.com/spectreconsole/spectre.console/pull/1456](https://github.com/spectreconsole/spectre.console/pull/1456)
- Don't erase secret prompt text upon backspace when mask is null by
[@&#8203;danielcweber](https://github.com/danielcweber) in
[https://github.com/spectreconsole/spectre.console/pull/1458](https://github.com/spectreconsole/spectre.console/pull/1458)
- Update dependencies to the latest version by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1459](https://github.com/spectreconsole/spectre.console/pull/1459)
- Automatically register command settings by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1463](https://github.com/spectreconsole/spectre.console/pull/1463)
- chore: Update dependency dotnet-example to v3.1.0 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/spectreconsole/spectre.console/pull/1470](https://github.com/spectreconsole/spectre.console/pull/1470)
- chore: Update dependency Roslynator.Analyzers to v4.11.0 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/spectreconsole/spectre.console/pull/1473](https://github.com/spectreconsole/spectre.console/pull/1473)
- Remove \[DebuggerDisplay] from Paragraph by
[@&#8203;martincostello](https://github.com/martincostello) in
[https://github.com/spectreconsole/spectre.console/pull/1477](https://github.com/spectreconsole/spectre.console/pull/1477)
- Selection Prompt Search by
[@&#8203;slang25](https://github.com/slang25) in
[https://github.com/spectreconsole/spectre.console/pull/1289](https://github.com/spectreconsole/spectre.console/pull/1289)
- Update dependency SixLabors.ImageSharp to v3.1.3 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/spectreconsole/spectre.console/pull/1486](https://github.com/spectreconsole/spectre.console/pull/1486)
- Positioned Progress Tasks - Before or After Other Tasks by
[@&#8203;thomhurst](https://github.com/thomhurst) in
[https://github.com/spectreconsole/spectre.console/pull/1250](https://github.com/spectreconsole/spectre.console/pull/1250)
- Added NoStackTrace to ExceptionFormats by
[@&#8203;gerardog](https://github.com/gerardog) in
[https://github.com/spectreconsole/spectre.console/pull/1489](https://github.com/spectreconsole/spectre.console/pull/1489)
- Pipe character for listing options (issue 1434) by
[@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1498](https://github.com/spectreconsole/spectre.console/pull/1498)
- Improve XmlDoc output by
[@&#8203;yenneferofvengerberg](https://github.com/yenneferofvengerberg)
in
[https://github.com/spectreconsole/spectre.console/pull/1503](https://github.com/spectreconsole/spectre.console/pull/1503)
- Revert
[`71a5d83`](https://github.com/spectreconsole/spectre.console/commit/71a5d830)
to undo flickering regression by
[@&#8203;phil-scott-78](https://github.com/phil-scott-78) in
[https://github.com/spectreconsole/spectre.console/pull/1504](https://github.com/spectreconsole/spectre.console/pull/1504)
- AddDelegate uses an abstract type when used in a branch by
[@&#8203;BlazeFace](https://github.com/BlazeFace) in
[https://github.com/spectreconsole/spectre.console/pull/1509](https://github.com/spectreconsole/spectre.console/pull/1509)
- Missing Separator When Headers are Hidden by
[@&#8203;BlazeFace](https://github.com/BlazeFace) in
[https://github.com/spectreconsole/spectre.console/pull/1513](https://github.com/spectreconsole/spectre.console/pull/1513)
- Expose raw arguments on the command context by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1523](https://github.com/spectreconsole/spectre.console/pull/1523)
- Add token representation to remaining arguments by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1525](https://github.com/spectreconsole/spectre.console/pull/1525)

##### New Contributors

- [@&#8203;baronfel](https://github.com/baronfel) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1425](https://github.com/spectreconsole/spectre.console/pull/1425)
- [@&#8203;DarqueWarrior](https://github.com/DarqueWarrior) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1431](https://github.com/spectreconsole/spectre.console/pull/1431)
- [@&#8203;tonycknight](https://github.com/tonycknight) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1435](https://github.com/spectreconsole/spectre.console/pull/1435)
- [@&#8203;caesay](https://github.com/caesay) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1439](https://github.com/spectreconsole/spectre.console/pull/1439)
- [@&#8203;jsheely](https://github.com/jsheely) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1414](https://github.com/spectreconsole/spectre.console/pull/1414)
- [@&#8203;danielcweber](https://github.com/danielcweber) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1456](https://github.com/spectreconsole/spectre.console/pull/1456)
- [@&#8203;martincostello](https://github.com/martincostello) made
their first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1477](https://github.com/spectreconsole/spectre.console/pull/1477)
- [@&#8203;slang25](https://github.com/slang25) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1289](https://github.com/spectreconsole/spectre.console/pull/1289)
- [@&#8203;thomhurst](https://github.com/thomhurst) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1250](https://github.com/spectreconsole/spectre.console/pull/1250)
- [@&#8203;gerardog](https://github.com/gerardog) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1489](https://github.com/spectreconsole/spectre.console/pull/1489)
-
[@&#8203;yenneferofvengerberg](https://github.com/yenneferofvengerberg)
made their first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1503](https://github.com/spectreconsole/spectre.console/pull/1503)
- [@&#8203;BlazeFace](https://github.com/BlazeFace) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1509](https://github.com/spectreconsole/spectre.console/pull/1509)

**Full Changelog**:
spectreconsole/spectre.console@0.48.0...0.49.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/buehler/dotnet-operator-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ian-buse referenced this pull request in dh2i-devs/dotnet-operator-sdk May 3, 2024
…ehler#751)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[Spectre.Console.Testing](https://github.com/spectreconsole/spectre.console)
| `0.48.0` -> `0.49.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>spectreconsole/spectre.console
(Spectre.Console.Testing)</summary>

###
[`v0.49.0`](https://github.com/spectreconsole/spectre.console/releases/tag/0.49.0)

[Compare
Source](https://github.com/spectreconsole/spectre.console/compare/0.48.0...0.49.0)

##### What's Changed

- Cleanup Line-Endings by [@&#8203;nils-a](https://github.com/nils-a)
in
[https://github.com/spectreconsole/spectre.console/pull/1381](https://github.com/spectreconsole/spectre.console/pull/1381)
- Added spectre.console.cli to quick-start. by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1413](https://github.com/spectreconsole/spectre.console/pull/1413)
- Fix rendering of ListPrompt for odd pageSizes by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1365](https://github.com/spectreconsole/spectre.console/pull/1365)
- Remove mandelbrot example due to conflicting license by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1426](https://github.com/spectreconsole/spectre.console/pull/1426)
- Allow specifying a property to ignore the use of build-time packages
for versioning and analysis by
[@&#8203;baronfel](https://github.com/baronfel) in
[https://github.com/spectreconsole/spectre.console/pull/1425](https://github.com/spectreconsole/spectre.console/pull/1425)
- Add the possibility to register multiple interceptors by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1412](https://github.com/spectreconsole/spectre.console/pull/1412)
- Added the ITypeResolver to the ExceptionHandler by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1411](https://github.com/spectreconsole/spectre.console/pull/1411)
- Updated typo in commandApp.md by
[@&#8203;DarqueWarrior](https://github.com/DarqueWarrior) in
[https://github.com/spectreconsole/spectre.console/pull/1431](https://github.com/spectreconsole/spectre.console/pull/1431)
- Command with -v displays app version instead of executing the command
by [@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1427](https://github.com/spectreconsole/spectre.console/pull/1427)
- HelpProvider colors should be configurable by
[@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1408](https://github.com/spectreconsole/spectre.console/pull/1408)
- Direct contributors to the current CONTRIBUTING.md by
[@&#8203;tonycknight](https://github.com/tonycknight) in
[https://github.com/spectreconsole/spectre.console/pull/1435](https://github.com/spectreconsole/spectre.console/pull/1435)
- Fix deadlock when cancelling prompts by
[@&#8203;caesay](https://github.com/caesay) in
[https://github.com/spectreconsole/spectre.console/pull/1439](https://github.com/spectreconsole/spectre.console/pull/1439)
- Add progress bar value formatter by
[@&#8203;jsheely](https://github.com/jsheely) in
[https://github.com/spectreconsole/spectre.console/pull/1414](https://github.com/spectreconsole/spectre.console/pull/1414)
- Update dependencies and do some clean-up by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1440](https://github.com/spectreconsole/spectre.console/pull/1440)
- Delete \[UsesVerify], which has become obsolete through the latest
update. by [@&#8203;danielcweber](https://github.com/danielcweber) in
[https://github.com/spectreconsole/spectre.console/pull/1456](https://github.com/spectreconsole/spectre.console/pull/1456)
- Don't erase secret prompt text upon backspace when mask is null by
[@&#8203;danielcweber](https://github.com/danielcweber) in
[https://github.com/spectreconsole/spectre.console/pull/1458](https://github.com/spectreconsole/spectre.console/pull/1458)
- Update dependencies to the latest version by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1459](https://github.com/spectreconsole/spectre.console/pull/1459)
- Automatically register command settings by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1463](https://github.com/spectreconsole/spectre.console/pull/1463)
- chore: Update dependency dotnet-example to v3.1.0 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/spectreconsole/spectre.console/pull/1470](https://github.com/spectreconsole/spectre.console/pull/1470)
- chore: Update dependency Roslynator.Analyzers to v4.11.0 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/spectreconsole/spectre.console/pull/1473](https://github.com/spectreconsole/spectre.console/pull/1473)
- Remove \[DebuggerDisplay] from Paragraph by
[@&#8203;martincostello](https://github.com/martincostello) in
[https://github.com/spectreconsole/spectre.console/pull/1477](https://github.com/spectreconsole/spectre.console/pull/1477)
- Selection Prompt Search by
[@&#8203;slang25](https://github.com/slang25) in
[https://github.com/spectreconsole/spectre.console/pull/1289](https://github.com/spectreconsole/spectre.console/pull/1289)
- Update dependency SixLabors.ImageSharp to v3.1.3 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/spectreconsole/spectre.console/pull/1486](https://github.com/spectreconsole/spectre.console/pull/1486)
- Positioned Progress Tasks - Before or After Other Tasks by
[@&#8203;thomhurst](https://github.com/thomhurst) in
[https://github.com/spectreconsole/spectre.console/pull/1250](https://github.com/spectreconsole/spectre.console/pull/1250)
- Added NoStackTrace to ExceptionFormats by
[@&#8203;gerardog](https://github.com/gerardog) in
[https://github.com/spectreconsole/spectre.console/pull/1489](https://github.com/spectreconsole/spectre.console/pull/1489)
- Pipe character for listing options (issue 1434) by
[@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1498](https://github.com/spectreconsole/spectre.console/pull/1498)
- Improve XmlDoc output by
[@&#8203;yenneferofvengerberg](https://github.com/yenneferofvengerberg)
in
[https://github.com/spectreconsole/spectre.console/pull/1503](https://github.com/spectreconsole/spectre.console/pull/1503)
- Revert
[`71a5d83`](https://github.com/spectreconsole/spectre.console/commit/71a5d830)
to undo flickering regression by
[@&#8203;phil-scott-78](https://github.com/phil-scott-78) in
[https://github.com/spectreconsole/spectre.console/pull/1504](https://github.com/spectreconsole/spectre.console/pull/1504)
- AddDelegate uses an abstract type when used in a branch by
[@&#8203;BlazeFace](https://github.com/BlazeFace) in
[https://github.com/spectreconsole/spectre.console/pull/1509](https://github.com/spectreconsole/spectre.console/pull/1509)
- Missing Separator When Headers are Hidden by
[@&#8203;BlazeFace](https://github.com/BlazeFace) in
[https://github.com/spectreconsole/spectre.console/pull/1513](https://github.com/spectreconsole/spectre.console/pull/1513)
- Expose raw arguments on the command context by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1523](https://github.com/spectreconsole/spectre.console/pull/1523)
- Add token representation to remaining arguments by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1525](https://github.com/spectreconsole/spectre.console/pull/1525)

##### New Contributors

- [@&#8203;baronfel](https://github.com/baronfel) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1425](https://github.com/spectreconsole/spectre.console/pull/1425)
- [@&#8203;DarqueWarrior](https://github.com/DarqueWarrior) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1431](https://github.com/spectreconsole/spectre.console/pull/1431)
- [@&#8203;tonycknight](https://github.com/tonycknight) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1435](https://github.com/spectreconsole/spectre.console/pull/1435)
- [@&#8203;caesay](https://github.com/caesay) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1439](https://github.com/spectreconsole/spectre.console/pull/1439)
- [@&#8203;jsheely](https://github.com/jsheely) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1414](https://github.com/spectreconsole/spectre.console/pull/1414)
- [@&#8203;danielcweber](https://github.com/danielcweber) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1456](https://github.com/spectreconsole/spectre.console/pull/1456)
- [@&#8203;martincostello](https://github.com/martincostello) made
their first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1477](https://github.com/spectreconsole/spectre.console/pull/1477)
- [@&#8203;slang25](https://github.com/slang25) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1289](https://github.com/spectreconsole/spectre.console/pull/1289)
- [@&#8203;thomhurst](https://github.com/thomhurst) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1250](https://github.com/spectreconsole/spectre.console/pull/1250)
- [@&#8203;gerardog](https://github.com/gerardog) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1489](https://github.com/spectreconsole/spectre.console/pull/1489)
-
[@&#8203;yenneferofvengerberg](https://github.com/yenneferofvengerberg)
made their first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1503](https://github.com/spectreconsole/spectre.console/pull/1503)
- [@&#8203;BlazeFace](https://github.com/BlazeFace) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1509](https://github.com/spectreconsole/spectre.console/pull/1509)

**Full Changelog**:
spectreconsole/spectre.console@0.48.0...0.49.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/buehler/dotnet-operator-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vgmello referenced this pull request in ellosoft/aws-cred-mgr May 31, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[Spectre.Console.Analyzer](https://github.com/spectreconsole/spectre.console)
| `0.48.0` -> `0.49.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Spectre.Console.Analyzer/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Spectre.Console.Analyzer/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Spectre.Console.Analyzer/0.48.0/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Spectre.Console.Analyzer/0.48.0/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[Spectre.Console.Cli](https://github.com/spectreconsole/spectre.console)
| `0.48.0` -> `0.49.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Spectre.Console.Cli/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Spectre.Console.Cli/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Spectre.Console.Cli/0.48.0/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Spectre.Console.Cli/0.48.0/0.49.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>spectreconsole/spectre.console
(Spectre.Console.Analyzer)</summary>

###
[`v0.49.1`](https://github.com/spectreconsole/spectre.console/compare/0.49.0...0.49.1)

[Compare
Source](https://github.com/spectreconsole/spectre.console/compare/0.49.0...0.49.1)

###
[`v0.49.0`](https://github.com/spectreconsole/spectre.console/releases/tag/0.49.0)

[Compare
Source](https://github.com/spectreconsole/spectre.console/compare/0.48.0...0.49.0)

#### What's Changed

- Cleanup line endings by [@&#8203;nils-a](https://github.com/nils-a)
in
[https://github.com/spectreconsole/spectre.console/pull/1381](https://github.com/spectreconsole/spectre.console/pull/1381)
- Added Spectre.Console.Cli to quick-start. by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1413](https://github.com/spectreconsole/spectre.console/pull/1413)
- Fix rendering of ListPrompt for odd pageSizes by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1365](https://github.com/spectreconsole/spectre.console/pull/1365)
- Remove mandelbrot example due to conflicting license by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1426](https://github.com/spectreconsole/spectre.console/pull/1426)
- Allow specifying a property to ignore the use of build-time packages
for versioning and analysis by
[@&#8203;baronfel](https://github.com/baronfel) in
[https://github.com/spectreconsole/spectre.console/pull/1425](https://github.com/spectreconsole/spectre.console/pull/1425)
- Add the possibility to register multiple interceptors by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1412](https://github.com/spectreconsole/spectre.console/pull/1412)
- Added the ITypeResolver to the ExceptionHandler by
[@&#8203;nils-a](https://github.com/nils-a) in
[https://github.com/spectreconsole/spectre.console/pull/1411](https://github.com/spectreconsole/spectre.console/pull/1411)
- Updated typo in CommandApp.md by
[@&#8203;DarqueWarrior](https://github.com/DarqueWarrior) in
[https://github.com/spectreconsole/spectre.console/pull/1431](https://github.com/spectreconsole/spectre.console/pull/1431)
- Command with -v displays app version instead of executing the command
by [@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1427](https://github.com/spectreconsole/spectre.console/pull/1427)
- HelpProvider colors should be configurable by
[@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1408](https://github.com/spectreconsole/spectre.console/pull/1408)
- Direct contributors to the current CONTRIBUTING.md by
[@&#8203;tonycknight](https://github.com/tonycknight) in
[https://github.com/spectreconsole/spectre.console/pull/1435](https://github.com/spectreconsole/spectre.console/pull/1435)
- Fix deadlock when cancelling prompts by
[@&#8203;caesay](https://github.com/caesay) in
[https://github.com/spectreconsole/spectre.console/pull/1439](https://github.com/spectreconsole/spectre.console/pull/1439)
- Add progress bar value formatter by
[@&#8203;jsheely](https://github.com/jsheely) in
[https://github.com/spectreconsole/spectre.console/pull/1414](https://github.com/spectreconsole/spectre.console/pull/1414)
- Update dependencies and do some clean-up by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1440](https://github.com/spectreconsole/spectre.console/pull/1440)
- Delete \[UsesVerify], which has become obsolete through the latest
update. by [@&#8203;danielcweber](https://github.com/danielcweber) in
[https://github.com/spectreconsole/spectre.console/pull/1456](https://github.com/spectreconsole/spectre.console/pull/1456)
- Don't erase secret prompt text upon backspace when mask is null by
[@&#8203;danielcweber](https://github.com/danielcweber) in
[https://github.com/spectreconsole/spectre.console/pull/1458](https://github.com/spectreconsole/spectre.console/pull/1458)
- Update dependencies to the latest version by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1459](https://github.com/spectreconsole/spectre.console/pull/1459)
- Automatically register command settings by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1463](https://github.com/spectreconsole/spectre.console/pull/1463)
- Remove \[DebuggerDisplay] from Paragraph by
[@&#8203;martincostello](https://github.com/martincostello) in
[https://github.com/spectreconsole/spectre.console/pull/1477](https://github.com/spectreconsole/spectre.console/pull/1477)
- Selection Prompt Search by
[@&#8203;slang25](https://github.com/slang25) in
[https://github.com/spectreconsole/spectre.console/pull/1289](https://github.com/spectreconsole/spectre.console/pull/1289)
- Update dependency SixLabors.ImageSharp to v3.1.3 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/spectreconsole/spectre.console/pull/1486](https://github.com/spectreconsole/spectre.console/pull/1486)
- Positioned Progress Tasks - Before or After Other Tasks by
[@&#8203;thomhurst](https://github.com/thomhurst) in
[https://github.com/spectreconsole/spectre.console/pull/1250](https://github.com/spectreconsole/spectre.console/pull/1250)
- Added NoStackTrace to ExceptionFormats by
[@&#8203;gerardog](https://github.com/gerardog) in
[https://github.com/spectreconsole/spectre.console/pull/1489](https://github.com/spectreconsole/spectre.console/pull/1489)
- Pipe character for listing options (issue 1434) by
[@&#8203;FrankRay78](https://github.com/FrankRay78) in
[https://github.com/spectreconsole/spectre.console/pull/1498](https://github.com/spectreconsole/spectre.console/pull/1498)
- Improve XmlDoc output by
[@&#8203;yenneferofvengerberg](https://github.com/yenneferofvengerberg)
in
[https://github.com/spectreconsole/spectre.console/pull/1503](https://github.com/spectreconsole/spectre.console/pull/1503)
- Revert
[`71a5d83`](https://github.com/spectreconsole/spectre.console/commit/71a5d830)
to undo flickering regression by
[@&#8203;phil-scott-78](https://github.com/phil-scott-78) in
[https://github.com/spectreconsole/spectre.console/pull/1504](https://github.com/spectreconsole/spectre.console/pull/1504)
- AddDelegate uses an abstract type when used in a branch by
[@&#8203;BlazeFace](https://github.com/BlazeFace) in
[https://github.com/spectreconsole/spectre.console/pull/1509](https://github.com/spectreconsole/spectre.console/pull/1509)
- Missing Separator When Headers are Hidden by
[@&#8203;BlazeFace](https://github.com/BlazeFace) in
[https://github.com/spectreconsole/spectre.console/pull/1513](https://github.com/spectreconsole/spectre.console/pull/1513)
- Expose raw arguments on the command context by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1523](https://github.com/spectreconsole/spectre.console/pull/1523)
- Add token representation to remaining arguments by
[@&#8203;patriksvensson](https://github.com/patriksvensson) in
[https://github.com/spectreconsole/spectre.console/pull/1525](https://github.com/spectreconsole/spectre.console/pull/1525)

#### New Contributors

- [@&#8203;baronfel](https://github.com/baronfel) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1425](https://github.com/spectreconsole/spectre.console/pull/1425)
- [@&#8203;DarqueWarrior](https://github.com/DarqueWarrior) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1431](https://github.com/spectreconsole/spectre.console/pull/1431)
- [@&#8203;tonycknight](https://github.com/tonycknight) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1435](https://github.com/spectreconsole/spectre.console/pull/1435)
- [@&#8203;caesay](https://github.com/caesay) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1439](https://github.com/spectreconsole/spectre.console/pull/1439)
- [@&#8203;jsheely](https://github.com/jsheely) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1414](https://github.com/spectreconsole/spectre.console/pull/1414)
- [@&#8203;danielcweber](https://github.com/danielcweber) made their
first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1456](https://github.com/spectreconsole/spectre.console/pull/1456)
- [@&#8203;martincostello](https://github.com/martincostello) made
their first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1477](https://github.com/spectreconsole/spectre.console/pull/1477)
- [@&#8203;slang25](https://github.com/slang25) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1289](https://github.com/spectreconsole/spectre.console/pull/1289)
- [@&#8203;thomhurst](https://github.com/thomhurst) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1250](https://github.com/spectreconsole/spectre.console/pull/1250)
- [@&#8203;gerardog](https://github.com/gerardog) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1489](https://github.com/spectreconsole/spectre.console/pull/1489)
-
[@&#8203;yenneferofvengerberg](https://github.com/yenneferofvengerberg)
made their first contribution in
[https://github.com/spectreconsole/spectre.console/pull/1503](https://github.com/spectreconsole/spectre.console/pull/1503)
- [@&#8203;BlazeFace](https://github.com/BlazeFace) made their first
contribution in
[https://github.com/spectreconsole/spectre.console/pull/1509](https://github.com/spectreconsole/spectre.console/pull/1509)

**Full Changelog**:
spectreconsole/spectre.console@0.48.0...0.49.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ellosoft/aws-cred-mgr).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@fihorvat
Copy link

@slang25 Sorry for the late comment but it looks like there is a bug. If you try to use something other than string for SelectionPrompt<T> in combination with the UseConverter the cursor selection doesn't work how it should.
Text highlighting works but the cursor doesn't move.

video

Here is a simple test data:

class TestItem
{
  public string Name { get; set; }
  public string Url { get; set; }
}

var items = new TestItem[] {
  new() { Name = "banana", Url = "something" },
  new() { Name = "orange", Url = "something" },
  new() { Name = "apple", Url = "something" }
};

var prompt = new SelectionPrompt<TestItem>()
  .Title("Select [green]fruit[/]?")
  .PageSize(10)
  .AddChoices(items)
  .UseConverter(x => x.Name)
  .EnableSearch();
prompt.SearchHighlightStyle(Style.Parse("yellow1"));
var response = AnsiConsole.Prompt(prompt);

And could you please add the method SearchHighlightStyle same as we have for HighlightStyle?

@patriksvensson
Copy link
Contributor

@fihorvat This PR had been merged and no further work is expected by the contributor. Please open a new issue if you experience any bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants