New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search bug in prompt related to custom item types #1627

Merged

patriksvensson merged 1 commit into spectreconsole:main from patriksvensson:feature/GH-1626

Sep 2, 2024

Contributor

patriksvensson commented Sep 2, 2024

Fixes #1626

I have read the Contribution Guidelines
I have commented on the issue above and discussed the intended changes
A maintainer has signed off on the changes and the issue was assigned to me
All newly added code is adequately covered by tests
All existing tests are still running without errors
The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

ListPromptState<T> now takes converter into account.

Please upvote 👍 this pull request if you are interested in it.


          Fix search bug in prompt related to custom item types

37ebfe6

Closes spectreconsole#1626

patriksvensson force-pushed the feature/GH-1626 branch from e5b30f1 to 37ebfe6 Compare

September 2, 2024 22:41

patriksvensson marked this pull request as ready for review

September 2, 2024 22:41

patriksvensson merged commit fd69ad0 into spectreconsole:main

3 checks passed

patriksvensson deleted the feature/GH-1626 branch

September 2, 2024 22:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet