Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign assemblies #687

Closed
wants to merge 1 commit into from
Closed

Conversation

sebastienros
Copy link

Fixes #481

At least to show what it would mean to have the assemblies signed. I created an .snk file. There is a warning since the Tests reference a non-signed assembly, which could use the same key (it can be reused as much as you want, nothing private to rely on in these).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@phil-scott-78
Copy link
Contributor

Good news and bad news.

  1. I'm gonna close this PR.
  2. The good news is that we are going to work on getting a seperate project released that is signed. Once we it is in place, I'll ping @sebastienros so you can check it out as a reviewer.

@lucaspimentel
Copy link

I'm gonna close this PR... a seperate project released that is signed

Any reason why you're not signing this project?

@KirillOsenkov
Copy link
Contributor

This PR would unblock a lot of people and it doesn't make anything worse. @patriksvensson

@KirillOsenkov KirillOsenkov mentioned this pull request Aug 29, 2024
6 tasks
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StrongNamed version of the assembly
6 participants