-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure plugin removal during Helm uninstall #111
Conversation
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 44.69% 45.06% +0.37%
==========================================
Files 9 9
Lines 810 801 -9
==========================================
- Hits 362 361 -1
+ Misses 425 417 -8
Partials 23 23
Continue to review full report in Codecov by Sentry.
|
433487c
to
0260e6c
Compare
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
0260e6c
to
50ec944
Compare
…rage Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I can see that cleanup is a tool which deletes k8s resources according to a config file that it expects to be at a particular path. Here, we put the config for what to delete into a ConfigMap and mount it to the pod that will be doing the cleanup, so that it knows what to delete.
Fixes #108. Use
spectro-cleanup
to delete theValidatorConfig
CR first, which ensures that validator garbage collects all installed plugins prior to Helm deleting validator.@karl-cardenas-coding the user will still need to execute
kubectl delete namespace validator
, as Helm does not remove the release namespace duringhelm uninstall
. See helm/helm#1464.