Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure plugin removal during Helm uninstall #111

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Nov 16, 2023

Fixes #108. Use spectro-cleanup to delete the ValidatorConfig CR first, which ensures that validator garbage collects all installed plugins prior to Helm deleting validator.

@karl-cardenas-coding the user will still need to execute kubectl delete namespace validator, as Helm does not remove the release namespace during helm uninstall. See helm/helm#1464.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #111 (cb4e86a) into main (855e70e) will increase coverage by 0.37%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   44.69%   45.06%   +0.37%     
==========================================
  Files           9        9              
  Lines         810      801       -9     
==========================================
- Hits          362      361       -1     
+ Misses        425      417       -8     
  Partials       23       23              
Files Coverage Δ
internal/controller/validatorconfig_controller.go 73.71% <100.00%> (+0.68%) ⬆️
internal/controller/validationresult_controller.go 72.72% <50.00%> (+4.64%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855e70e...cb4e86a. Read the comment docs.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
…rage

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link
Member

@mattwelke mattwelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can see that cleanup is a tool which deletes k8s resources according to a config file that it expects to be at a particular path. Here, we put the config for what to delete into a ConfigMap and mount it to the pod that will be doing the cleanup, so that it knows what to delete.

@TylerGillson TylerGillson merged commit 0917418 into main Nov 16, 2023
7 checks passed
@TylerGillson TylerGillson deleted the helm-cleanup branch November 16, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Uninstall Issue
2 participants