Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete plugins in parallel to avoid hitting timeouts #141

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

ahmad-ibra
Copy link
Contributor

@ahmad-ibra ahmad-ibra commented Nov 30, 2023

When a certain threshold is passed in number of plugins running, plugin helm chart deletion via the validator-cleanup job fails due to timeouts. The idea hear is to parallelize the chart deletions via goroutines to reduce the risk of this happening.

@ahmad-ibra ahmad-ibra marked this pull request as draft November 30, 2023 22:12
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #141 (97978e9) into main (3ae7b70) will increase coverage by 0.66%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   55.17%   55.84%   +0.66%     
==========================================
  Files           9        9              
  Lines         850      856       +6     
==========================================
+ Hits          469      478       +9     
+ Misses        354      353       -1     
+ Partials       27       25       -2     
Files Coverage Δ
internal/controller/validatorconfig_controller.go 76.88% <100.00%> (+2.00%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae7b70...97978e9. Read the comment docs.

Copy link
Member

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the timeout alone for now and keep adding plugins until it breaks again 😝

I say that because the full timeout is respected regardless of the # of plugins. So it would suck if users had to wait 15s for helm uninstall if there's only 1 plugin. I'd rather wait and find out how far these changes will get us.

@TylerGillson TylerGillson marked this pull request as ready for review December 1, 2023 01:58
@TylerGillson TylerGillson merged commit a3fc0dc into main Dec 1, 2023
7 checks passed
@TylerGillson TylerGillson deleted the parallel-plugin-delete branch December 1, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants