-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete plugins in parallel to avoid hitting timeouts #141
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 55.17% 55.84% +0.66%
==========================================
Files 9 9
Lines 850 856 +6
==========================================
+ Hits 469 478 +9
+ Misses 354 353 -1
+ Partials 27 25 -2
Continue to review full report in Codecov by Sentry.
|
866b478
to
ea5b412
Compare
ea5b412
to
97978e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave the timeout alone for now and keep adding plugins until it breaks again 😝
I say that because the full timeout is respected regardless of the # of plugins. So it would suck if users had to wait 15s for helm uninstall
if there's only 1 plugin. I'd rather wait and find out how far these changes will get us.
When a certain threshold is passed in number of plugins running, plugin helm chart deletion via the
validator-cleanup
job fails due to timeouts. The idea hear is to parallelize the chart deletions via goroutines to reduce the risk of this happening.