Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Data Netplan #1705

Merged
merged 9 commits into from
Oct 25, 2023
Merged

User Data Netplan #1705

merged 9 commits into from
Oct 25, 2023

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Oct 24, 2023

Describe the Change

This PR updates the cloud-init.md file to add a Netplan network configuration section.

Review Changes

💻 Preview URL

🎫 PE-2882

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit e5b5c2d
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65395626a099da000842243b
😎 Deploy Preview https://deploy-preview-1705--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome addition 😄

caroldelwing and others added 2 commits October 25, 2023 13:33
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
@caroldelwing caroldelwing marked this pull request as ready for review October 25, 2023 17:46
@caroldelwing caroldelwing requested a review from a team as a code owner October 25, 2023 17:46
@caroldelwing caroldelwing merged commit 05f011b into master Oct 25, 2023
7 checks passed
@caroldelwing caroldelwing deleted the userdata-netplan branch October 25, 2023 19:03
@caroldelwing caroldelwing added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 labels Oct 25, 2023
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 25, 2023
* docs: initial draft

* docs: updated cloud-init.md with Netplan network configuration section

* docs: fixed link on cloud-init.md file

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* docs: added tip section PE-2882

* chore: updated Vale vocabs

---------

Co-authored-by: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 05f011b)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- docs: updated URLs to use file path context

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 1705

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

caroldelwing added a commit that referenced this pull request Oct 25, 2023
* docs: initial draft

* docs: updated cloud-init.md with Netplan network configuration section

* docs: fixed link on cloud-init.md file

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* docs: added tip section PE-2882

* chore: updated Vale vocabs

---------

Co-authored-by: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit 05f011b)

Co-authored-by: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
@karl-cardenas-coding karl-cardenas-coding added the backport-version-4-1 Backport change to version 4.1 label Oct 25, 2023
karl-cardenas-coding added a commit that referenced this pull request Oct 25, 2023
* docs: initial draft

* docs: updated cloud-init.md with Netplan network configuration section

* docs: fixed link on cloud-init.md file

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* docs: added tip section PE-2882

* chore: updated Vale vocabs

---------

Co-authored-by: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
@karl-cardenas-coding
Copy link
Contributor

Backport for 3.4 is handled with #1709

caroldelwing added a commit that referenced this pull request Oct 25, 2023
* docs: initial draft

* docs: updated cloud-init.md with Netplan network configuration section

* docs: fixed link on cloud-init.md file

* Apply suggestions from code review

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* docs: added tip section PE-2882

* chore: updated Vale vocabs

---------

Co-authored-by: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
@caroldelwing
Copy link
Contributor Author

Backport for 4.1 handled.

caroldelwing added a commit that referenced this pull request Oct 25, 2023
* docs: initial draft

* docs: updated cloud-init.md with Netplan network configuration section

* docs: fixed link on cloud-init.md file

* Apply suggestions from code review



* docs: added tip section PE-2882

* chore: updated Vale vocabs

---------

Co-authored-by: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants