Document addition of namespace labels for pods needing elevated privileges #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lennessyy
changed the title
ritawatson
reviewed
Oct 24, 2023
ritawatson
reviewed
Oct 24, 2023
ritawatson
reviewed
Oct 24, 2023
ritawatson
reviewed
Oct 24, 2023
ritawatson
reviewed
Oct 24, 2023
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
ritawatson
reviewed
Oct 25, 2023
ritawatson
reviewed
Oct 25, 2023
ritawatson
reviewed
Oct 25, 2023
ritawatson
reviewed
Oct 25, 2023
ritawatson
reviewed
Oct 25, 2023
ritawatson
reviewed
Oct 25, 2023
ritawatson
reviewed
Oct 25, 2023
ritawatson
reviewed
Oct 25, 2023
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
…pectrocloud/librarium into namespace-elevated-priviledges
ritawatson
suggested changes
Oct 25, 2023
|
Great use of a tip. :) |
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@lennessyy Check your content for ableism. I saw the term "running", you can replace this with non-ableism terms, such as "active" |
ritawatson
approved these changes
Oct 25, 2023
|
@karl-cardenas-coding I just checked - there are two instances of the word "running" in this page, and they both are from a section not touched by this PR. I was going to correct those following your comment, but those instances refer to the pods in "running" stage. I wonder if this is the literal word that is used in kubectl when someone uses "kubectl get pods", and it might be confusing if we changed it to something else. |
|
In that case, you can leave them. I skimmed so I missed the context. But yes, that is a correct context and usage of referring to the k8s term. |
vishwanaths
reviewed
Oct 26, 2023
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
…elevated privileges (#1706) * PAC-828 Document addition of namespace labels for pods needing elevated privileges * fix formatting * clarify cluster profile * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Style guide edits * Add clarification for multiple namespaces * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Incorporate feedback * Incorporate feedback * vale comments * change step numbers * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Add second example * vale comments * second person voice * Explicitly call out how to provide versions --------- Co-authored-by: Lenny Chen <lennychen@Waterdeep.local> Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com> (cherry picked from commit d621475)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
lennessyy
added a commit
that referenced
this pull request
Oct 26, 2023
…elevated privileges (#1706) (#1713) * PAC-828 Document addition of namespace labels for pods needing elevated privileges * fix formatting * clarify cluster profile * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Style guide edits * Add clarification for multiple namespaces * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Incorporate feedback * Incorporate feedback * vale comments * change step numbers * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Update docs/docs-content/troubleshooting/cluster-deployment.md Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> * Add second example * vale comments * second person voice * Explicitly call out how to provide versions --------- Co-authored-by: Lenny Chen <lennychen@Waterdeep.local> Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> Co-authored-by: Lenny Chen <lenny.chen@spectrocloud.com> (cherry picked from commit d621475) Co-authored-by: Lenny Chen <55669665+lennessyy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR adds the steps to change Pod Security Standards by applying labels to namespaces if users encounter problems during deployment of cluster profiles with Packs that require elevated privileges.
Review Changes
💻 Preview
🎫 PAC-828