Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Proposal #1710

Merged
merged 11 commits into from
Oct 27, 2023
Merged

CI Proposal #1710

merged 11 commits into from
Oct 27, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

Describe the Change

This PR changes the CI workflow to address several of the items discussed in the team meeting.

Review Changes

💻 Add Preview URL

🎫 Jira Ticket

@karl-cardenas-coding karl-cardenas-coding added CI/CD CI/CD related changes backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 labels Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 6221319
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/653adb46476f160008f1a5c0
😎 Deploy Preview https://deploy-preview-1710--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review October 27, 2023 01:27
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner October 27, 2023 01:27
caroldelwing
caroldelwing approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through it, and everything looks good to me.

@karl-cardenas-coding karl-cardenas-coding merged commit 0a09dd0 into master Oct 27, 2023
@karl-cardenas-coding karl-cardenas-coding deleted the ci-improvements branch October 27, 2023 14:39
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- ci: update to the backport post-PRs CI/CD (#1584)
- docs: repave clarifications (#1548)
- chore: released docs versioning
- docs: palette-cli URL update
❌ version-4-1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 1710

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

This was referenced Oct 27, 2023
Merged
Merged
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Oct 27, 2023
Merged
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Oct 27, 2023
Merged
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Nov 1, 2023
Merged
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Mar 1, 2024
Merged
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Apr 2, 2024
Merged
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 2, 2024
Merged
2 tasks
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Aug 29, 2024
Merged
2 tasks
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroldelwing caroldelwing caroldelwing approved these changes

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

@ritawatson ritawatson Awaiting requested review from ritawatson ritawatson is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 CI/CD CI/CD related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karl-cardenas-coding @caroldelwing