Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vale to accept PCGs, vCPU, and vCPUs #2246

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update Vale to accept PCGs, vCPU, and vCPUs #2246

merged 1 commit into from
Feb 16, 2024

Conversation

yuliiiah
Copy link
Contributor

Describe the Change

This PR updates the list of words allowed by Vale.

Review Changes

🎫 DOC-1074

@yuliiiah yuliiiah requested a review from a team as a code owner February 16, 2024 16:59
@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 12baf49
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65cf947034215b0008b74e2d
😎 Deploy Preview https://deploy-preview-2246--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuliiiah yuliiiah added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 labels Feb 16, 2024
caroldelwing
caroldelwing approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✅✨

@yuliiiah yuliiiah merged commit 5ef0de6 into master Feb 16, 2024
15 checks passed
@yuliiiah yuliiiah deleted the doc-1074 branch February 16, 2024 17:11
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- docs: Provide missing Autocale information (#1857) DOC-897
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- docs: Provide missing Autocale information (#1857) DOC-897
- docs: added keycloak How-to (#1839)
❌ version-4-1 Backport failed because of merge conflicts
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- docs: add instructions for connecting edge host to wifi (#2092)

Manual backport

To create the backport manually run:

backport --pr 2246

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246)
26b8e8a
@yuliiiah yuliiiah mentioned this pull request Feb 16, 2024
Merged
yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246)
fa5fe6c
@yuliiiah yuliiiah mentioned this pull request Feb 16, 2024
Merged
yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246)
c7ca79d
@yuliiiah yuliiiah mentioned this pull request Feb 16, 2024
Merged
yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246)
f11283b
@yuliiiah yuliiiah mentioned this pull request Feb 16, 2024
Merged
yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246) (#2247)
0b8879e
yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246) (#2248)
6ae9713
yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246) (#2249)
98b1d70
yuliiiah added a commit that referenced this pull request Feb 16, 2024
@yuliiiah
chore: Update Vale to accept PCGs, vCPU, and vCPUs (#2246) (#2250)
ec906a8
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroldelwing caroldelwing caroldelwing approved these changes

@karl-cardenas-coding karl-cardenas-coding Awaiting requested review from karl-cardenas-coding karl-cardenas-coding is a code owner automatically assigned from spectrocloud/docs-education

@addetz addetz Awaiting requested review from addetz addetz is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuliiiah @caroldelwing