Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add acronym rule to vale DOC-940 #2273

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

addetz
Copy link
Contributor

@addetz addetz commented Feb 22, 2024

Describe the Change

This PR adds a vale rule that ensures acronyms are defined using title case, as described in our style guide.
This rule applies to acronyms of 2-5 characters length.

Review Changes

💻 Add Preview URL

🎫 Jira Ticket

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 579efd5
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65d76efc87693600086d8026
😎 Deploy Preview https://deploy-preview-2273--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 87cdeec
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65d777d85a583500089172bb
😎 Deploy Preview https://deploy-preview-2273--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@addetz addetz force-pushed the add-vale-capitalisation-doc-940 branch from 0ebb01b to 87cdeec Compare February 22, 2024 16:35
@addetz addetz added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 labels Feb 22, 2024
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the rule and it works in catching

@addetz addetz merged commit b5905d9 into master Feb 22, 2024
15 checks passed
@addetz addetz deleted the add-vale-capitalisation-doc-940 branch February 22, 2024 18:54
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1
version-4-2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 22, 2024
* chore: add acronym rule to vale DOC-940

* chore: add more ignore extensions

(cherry picked from commit b5905d9)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
addetz added a commit that referenced this pull request Feb 23, 2024
addetz added a commit that referenced this pull request Feb 23, 2024
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 23, 2024
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 23, 2024
This reverts commit b5905d9.

(cherry picked from commit e1acc2d)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants