Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wording of pxk #4197

Merged
merged 5 commits into from
Oct 4, 2024
Merged

fix wording of pxk #4197

merged 5 commits into from
Oct 4, 2024

Conversation

wcrum
Copy link
Member

@wcrum wcrum commented Oct 4, 2024

Describe the Change

This PR ....

Changed Pages

💻 Add Preview URL for Page

Jira Tickets

🎫 Jira Ticket

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@wcrum wcrum requested a review from a team as a code owner October 4, 2024 16:53
@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 39bbf92
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/670044aef2e6e900085f29c0
😎 Deploy Preview https://deploy-preview-4197--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Oct 4, 2024
View reviewed changes
docs/docs-content/integrations/kubernetes.md Outdated Show resolved Hide resolved
docs/docs-content/glossary-all.md Outdated Show resolved Hide resolved
docs/docs-content/glossary-all.md Outdated Show resolved Hide resolved
docs/docs-content/glossary-all.md Show resolved Hide resolved
docs/docs-content/glossary-all.md Show resolved Hide resolved
karl-cardenas-coding
karl-cardenas-coding approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wcrum

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Oct 4, 2024
@karl-cardenas-coding karl-cardenas-coding merged commit 860b2a1 into master Oct 4, 2024
15 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the pxk-wording-wcrum branch October 4, 2024 21:58
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 4, 2024
@wcrum
chore: correct wording of pxk (#4197)
df16f22 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: wcrum <wcrum@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
(cherry picked from commit 860b2a1)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Oct 4, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- docs: DOC-1118 Image Conversion to webp (#2439)
- chore: upgrade to docusaurus 3.1.1 (#2135)
- Refactor/restructure cluster & app profiles sections (#1551)
- docs: updated URLs to use file path context
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- chore: PAC-938-packs data initial fetch and component development for readme (#3178)
- docs: DOC-1118 Image Conversion to webp (#2439)
- Refactor/restructure cluster & app profiles sections (#1551)
- docs: repave clarifications (#1548)
- docs: updated URLs to use file path context
❌ version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- docs: DOC-1118 Image Conversion to webp (#2439)
- chore: upgrade to docusaurus 3.1.1 (#2135)
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- docs: DOC-1118 Image Conversion to webp (#2439)
- chore: upgrade to docusaurus 3.1.1 (#2135)
❌ version-4-3 Backport failed because of merge conflicts
✅ version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 4197

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 4, 2024
@vault-token-factory-spectrocloud @wcrum
chore: correct wording of pxk (#4197) (#4199)
7165fe2 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: wcrum <wcrum@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
(cherry picked from commit 860b2a1)

Co-authored-by: will <30413278+wcrum@users.noreply.github.com>
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@wcrum @karl-cardenas-coding
chore: correct wording of pxk (#4197)
7eea5dd 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: wcrum <wcrum@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Oct 4, 2024
Merged
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@wcrum @karl-cardenas-coding
chore: correct wording of pxk (#4197)
59d0bba 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: wcrum <wcrum@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Oct 4, 2024
Merged
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@wcrum @karl-cardenas-coding
chore: correct wording of pxk (#4197)
05ca839 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: wcrum <wcrum@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Oct 4, 2024
Merged
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@wcrum @karl-cardenas-coding
chore: correct wording of pxk (#4197)
8fdd19d 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: wcrum <wcrum@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Oct 4, 2024
Merged
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@wcrum @karl-cardenas-coding
chore: correct wording of pxk (#4197)
97b66d1 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: wcrum <wcrum@users.noreply.github.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Karl Cardenas <29551334+karl-cardenas-coding@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Oct 4, 2024
Merged
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@karl-cardenas-coding @wcrum
chore: correct wording of pxk (#4197) (#4200)
c21108e 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: will <30413278+wcrum@users.noreply.github.com>
Co-authored-by: wcrum <wcrum@users.noreply.github.com>
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@karl-cardenas-coding @wcrum
chore: correct wording of pxk (#4197) (#4201)
9e258b2 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: will <30413278+wcrum@users.noreply.github.com>
Co-authored-by: wcrum <wcrum@users.noreply.github.com>
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@karl-cardenas-coding @wcrum
chore: correct wording of pxk (#4197) (#4202)
d75fcf5 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: will <30413278+wcrum@users.noreply.github.com>
Co-authored-by: wcrum <wcrum@users.noreply.github.com>
karl-cardenas-coding added a commit that referenced this pull request Oct 4, 2024
@karl-cardenas-coding @wcrum
chore: correct wording of pxk (#4197) (#4203)
94864e1 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: will <30413278+wcrum@users.noreply.github.com>
Co-authored-by: wcrum <wcrum@users.noreply.github.com>
karl-cardenas-coding added a commit that referenced this pull request Oct 5, 2024
@karl-cardenas-coding @wcrum
chore: correct wording of pxk (#4197) (#4204)
c96d76c 
* fix wording of pxk

* ci: auto-formatting prettier issues

* docs: more content

* docs: vale suggestions

---------

Co-authored-by: will <30413278+wcrum@users.noreply.github.com>
Co-authored-by: wcrum <wcrum@users.noreply.github.com>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

@addetz addetz Awaiting requested review from addetz addetz is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

@caroldelwing caroldelwing Awaiting requested review from caroldelwing caroldelwing is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcrum @karl-cardenas-coding