Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update url mapper component #4305

Merged
merged 3 commits into from
Oct 17, 2024
Merged

docs: update url mapper component #4305

merged 3 commits into from
Oct 17, 2024

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Oct 17, 2024

Describe the Change

This PR updates the PaletteVertexUrlMapper component to handle cases where Palette and Vertex have different URLs beyond the base path. If the pages share the same URL, the component continues to function as it always has.

Two new optional props have been added to accommodate the different URLs: palettePath and vertexPath.

This PR also addresses feedback from Appzi.

Changed Pages

💻 PCG

Jira Tickets

🎫 DOC-1427

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 19cc766
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6711586ce29ede000848f8ed
😎 Deploy Preview https://deploy-preview-4305--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@caroldelwing caroldelwing marked this pull request as ready for review October 17, 2024 15:58
@caroldelwing caroldelwing requested a review from a team as a code owner October 17, 2024 15:58
@caroldelwing caroldelwing added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. labels Oct 17, 2024
Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful addition! 🚀

@caroldelwing caroldelwing merged commit eac75f5 into master Oct 17, 2024
17 checks passed
@caroldelwing caroldelwing deleted the update-url-mapper branch October 17, 2024 18:59
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- docs: unhyphenate open source (#4284)
- docs: pxk-license (#4258)
- docs: remove free-tier mention (#4220)
version-4-1
version-4-2
version-4-3
version-4-4
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 4305

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback

(cherry picked from commit eac75f5)

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
caroldelwing added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback
caroldelwing added a commit that referenced this pull request Oct 17, 2024
* docs: update url mapper component

* docs: address suggestions, address appzi feedback
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants