Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove double slashes from image reference DOC-1232 #4429

Merged
merged 1 commit into from
Oct 23, 2024
Merged

docs: remove double slashes from image reference DOC-1232 #4429

merged 1 commit into from
Oct 23, 2024

Conversation

addetz
Copy link
Contributor

@addetz addetz commented Oct 23, 2024 •
edited
Loading

Describe the Change

This PR removes the double slashes from the keycloak guide. While this renders correctly, it is wrong syntax and breaks the unused image detection automation.

Changed Pages

💻 Keycloak

Jira Tickets

🎫 DOC-1232

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@addetz addetz requested a review from a team as a code owner October 23, 2024 14:28
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 6c4dcf9
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/671907f50078f60008d10566
😎 Deploy Preview https://deploy-preview-4429--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@addetz addetz added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. labels Oct 23, 2024
caroldelwing
caroldelwing approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@addetz addetz merged commit e7231b8 into master Oct 23, 2024
29 checks passed
@addetz addetz deleted the remove-double-dash-keycloak branch October 23, 2024 14:49
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429)
189a480 
(cherry picked from commit e7231b8)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Oct 23, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429)
675ee64 
(cherry picked from commit e7231b8)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Oct 23, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- docs: unhyphenate open source (#4284)
- docs: DOC-1118 Image Conversion to webp (#2439)
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- docs: unhyphenate open source (#4284)
- docs: DOC-1118 Image Conversion to webp (#2439)
- docs: added keycloak How-to (#1839)
❌ version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- docs: unhyphenate open source (#4284)
- docs: DOC-1118 Image Conversion to webp (#2439)
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- docs: unhyphenate open source (#4284)
- docs: DOC-1118 Image Conversion to webp (#2439)
- replace caution with warning (#2039)
❌ version-4-3 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-3:
- docs: unhyphenate open source (#4284)
✅ version-4-4
✅ version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 4429

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429)
6749e87
@addetz addetz mentioned this pull request Oct 23, 2024
Merged
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429)
bc23fe3
@addetz addetz mentioned this pull request Oct 23, 2024
Merged
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429)
fd7786d
@addetz addetz mentioned this pull request Oct 23, 2024
Merged
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429)
4e025b5
@addetz addetz mentioned this pull request Oct 23, 2024
Merged
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 23, 2024
@vault-token-factory-spectrocloud @addetz
docs: remove double slashes from image reference DOC-1232 (#4429) (#4431
874da25 
)

(cherry picked from commit e7231b8)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 23, 2024
@vault-token-factory-spectrocloud @addetz
docs: remove double slashes from image reference DOC-1232 (#4429) (#4430
69ad5eb 
)

(cherry picked from commit e7231b8)

Co-authored-by: Adelina Simion <43963729+addetz@users.noreply.github.com>
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429)
3766ed3
@addetz addetz mentioned this pull request Oct 23, 2024
Merged
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429) (#4432
8f64ea9 
)
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429) (#4433
4e6dbad 
)
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429) (#4434
5f0fded 
)
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429) (#4435
79b41c8 
)
addetz added a commit that referenced this pull request Oct 23, 2024
@addetz
docs: remove double slashes from image reference DOC-1232 (#4429) (#4436
f29b259 
)
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroldelwing caroldelwing caroldelwing approved these changes

@benradstone benradstone benradstone approved these changes

@karl-cardenas-coding karl-cardenas-coding Awaiting requested review from karl-cardenas-coding karl-cardenas-coding is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addetz @benradstone @caroldelwing