Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about vddk secret namespace #4713

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

arturshadnik
Copy link
Contributor

@arturshadnik arturshadnik commented Nov 14, 2024

Describe the Change

This PR adds a note to the page about VM migration to VMO, directing the user to leave namespace blank when creating a vddk-image-pull-secret yaml.

Changed Pages

💻 Preview

Jira Tickets

🎫 Jira Ticket

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@arturshadnik arturshadnik added the backport-version-4-5 Backport changes to the version-4-5 branch. label Nov 14, 2024
@arturshadnik arturshadnik requested a review from a team as a code owner November 14, 2024 02:44
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 6b6a8bd
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6735d5cd7915930008b7a63a
😎 Deploy Preview https://deploy-preview-4713--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benradstone benradstone added the auto-backport Enable backport label Nov 14, 2024
@benradstone benradstone merged commit a8526fb into master Nov 14, 2024
15 checks passed
@benradstone benradstone deleted the docs/vddk-secret-ns branch November 14, 2024 11:00
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 14, 2024
* docs: add note about vddk secret namespace

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>

* ci: auto-formatting prettier issues

* docs: code review

---------

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Co-authored-by: arturshadnik <arturshadnik@users.noreply.github.com>
Co-authored-by: Ben Radstone <56587332+benradstone@users.noreply.github.com>
(cherry picked from commit a8526fb)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Nov 14, 2024
* docs: add note about vddk secret namespace

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>

* ci: auto-formatting prettier issues

* docs: code review

---------

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Co-authored-by: arturshadnik <arturshadnik@users.noreply.github.com>
Co-authored-by: Ben Radstone <56587332+benradstone@users.noreply.github.com>
(cherry picked from commit a8526fb)

Co-authored-by: Artur Shad Nik <37195151+arturshadnik@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 auto-backport Enable backport and removed auto-backport Enable backport backport-version-4-5 Backport changes to the version-4-5 branch. labels Nov 14, 2024
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants