Fix: Resolves #66. Allows backslash inside parenthesis, even without quotes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codito Hi. I was just looking at this and #65. How much of an effort would it be to pull these in https://github.com/spekt/testlogger so we can make these changes in one place? Also, i'm not sure whats going on with Appveyor... I didn't change the dependencies. |
|
Hi @Siphonophora, good idea. It's probably a weekend of refactoring. I will try to find some time for this. |
Merged
Siphonophora
added a commit
to spekt/junit.testlogger
that referenced
this pull request
Sep 25, 2020
codito
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #66 . It doesn't seem like it would be a common issue, but this should be safe to change.