Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed symbols and source code for test logger for debuggability. #23

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

codito
Copy link
Contributor

@codito codito commented Jul 26, 2021

With embedded symbols and sources, VS will be able to extract the source code and allow stepping without cloning the repo etc. This improves productivity at the cost of a slightly higher assembly size (+20kb).

@codito codito requested a review from Siphonophora July 26, 2021 15:08
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #23 (ddab3ad) into master (86d5ab9) will not change coverage.
The diff coverage is n/a.

❗ Current head ddab3ad differs from pull request most recent head 28cf3da. Consider uploading reports for the commit 28cf3da to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          522       522           
=========================================
  Hits           522       522           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d5ab9...28cf3da. Read the comment docs.

@codito codito mentioned this pull request Jul 26, 2021
Copy link
Contributor

@Siphonophora Siphonophora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this should be convenient.

@codito codito merged commit 65d52da into spekt:master Jul 27, 2021
@codito codito deleted the embedded-symbols branch July 27, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants