Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Recent Changes caused Lint Problems #631

Closed
Cictrone opened this issue Feb 20, 2024 · 0 comments · Fixed by #639
Closed

[bug] Recent Changes caused Lint Problems #631

Cictrone opened this issue Feb 20, 2024 · 0 comments · Fixed by #639
Assignees
Labels
bug Something isn't working cleanup Code cleanup and tech debt removal
Milestone

Comments

@Cictrone
Copy link
Collaborator

Describe the bug
#627 introduced lint problems in implants/lib/eldritch/src/file/read_impl.rs and #611 introduced lint problems in implants/lib/eldritch/src/runtime/eval.rs. They should be fixed at maximum priority. Moving forward we may start blocking merges if lint does not pass.

To Reproduce
Open repo in codespaces and see lint problems.

Expected behavior
All merged code should have zero lint problems unless apart of some larger body of work.

@Cictrone Cictrone added bug Something isn't working cleanup Code cleanup and tech debt removal labels Feb 20, 2024
@Cictrone Cictrone added this to the v0.1.0 milestone Feb 20, 2024
@hulto hulto linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup Code cleanup and tech debt removal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants