-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eprint function #611
Add eprint function #611
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 71.24% 71.35% +0.10%
==========================================
Files 168 169 +1
Lines 11224 11265 +41
==========================================
+ Hits 7997 8038 +41
Misses 3023 3023
Partials 204 204 ☔ View full report in Codecov by Sentry. |
#[allow(unused_variables)] | ||
fn eprint(starlark_eval: &mut Evaluator<'v, '_>, message: String) -> anyhow::Result<NoneType> { | ||
let env = crate::runtime::Environment::from_extra(starlark_eval.extra)?; | ||
eprint_impl::eprint(env, message)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that we pass env here, greatly demonstrates the separation between eprint (starlark) and eprint_impl (native rust)
Ignoring golem interactive for now tracking here: |
What type of PR is this?
/kind feature
What this PR does / why we need it:
eprint
function to allow users to emit errors manually.eprint
to a native functioneprint
in golem interactive.Which issue(s) this PR fixes:
Fixes #610