Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tavern] Added basic logging for GraphQL and HTTP #107

Merged
merged 1 commit into from
Feb 17, 2023
Merged

[Tavern] Added basic logging for GraphQL and HTTP #107

merged 1 commit into from
Feb 17, 2023

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds logging for GraphQL and HTTP requests.

@KCarretto KCarretto requested a review from hulto February 17, 2023 21:56
hulto
hulto reviewed Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these logs intended to be operation logs or debug logs?
If operation logs may want more verbosity what systems commands were queued on

tavern/app.go Show resolved Hide resolved
@KCarretto KCarretto merged commit f58fcbe into main Feb 17, 2023
@KCarretto KCarretto deleted the logging branch February 17, 2023 22:46
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
fbaf57c 
 
Added basic logging for GraphQL and HTTP (#107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KCarretto @hulto