Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug tcp scan test failures #142

Merged
merged 10 commits into from
Mar 7, 2023
Merged

Debug tcp scan test failures #142

merged 10 commits into from
Mar 7, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 7, 2023

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #127

@hulto hulto added the bug Something isn't working label Mar 7, 2023
@hulto hulto requested a review from Cictrone March 7, 2023 00:12
@hulto hulto linked an issue Mar 7, 2023 that may be closed by this pull request
[bug][eldritch] allocate_unusued_ports fails when port is already in use. #127
Closed
KCarretto
KCarretto approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change

implants/eldritch/src/pivot/port_scan_impl.rs Outdated
_ => {
return Err(anyhow::Error::from(err));
return Err(anyhow::anyhow!("Any unexpeceted error occured during the scan:\n{}", err));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Unexpected

implants/eldritch/src/pivot/port_scan_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/pivot/port_scan_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/pivot/port_scan_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/pivot/port_scan_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/pivot/port_scan_impl.rs Show resolved Hide resolved
implants/eldritch/src/pivot/port_scan_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/pivot/port_scan_impl.rs Outdated Show resolved Hide resolved
@hulto hulto merged commit 045bfac into main Mar 7, 2023
@hulto hulto deleted the debug-tcp-scan-test-failures branch March 7, 2023 05:05
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
41d136c 
 
Debug tcp scan test failures (#142)

* Port scan improved error handling.

* Resolved race condition

* Resolved conversation.

* Resolve conversation.

* Merging

* Nit wording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KCarretto KCarretto KCarretto approved these changes

@Cictrone Cictrone Awaiting requested review from Cictrone

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug][eldritch] allocate_unusued_ports fails when port is already in use.
2 participants
@hulto @KCarretto