-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement caching for GitHub Actions CI #157
Conversation
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 54.15% 54.15%
=======================================
Files 27 27
Lines 1313 1313
=======================================
Hits 711 711
Misses 531 531
Partials 71 71 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR does not address tavern build times (14 minutes !), but it would probably benefit from something similar. |
.github/workflows/tests.yml
Outdated
toolchain: stable | ||
default: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the toolchain in stable, @ reviewers please let me know problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Idk what's going on with the tool chain.
Might be getting overridden by the local toolchain.
If so we should either remove the toolchain specification from the CI or make them match.
I'll try to switch us to stable so it doesn't matter.
Implement caching for GitHub Actions CI (#157) * Add docker image cache * Use GHA cache type * Ah, this is the release. Remove changes. * Use rust-cache@v2 * Bump timeout to 15 minutes * Specify Eldritch workspace for rust-cache * Fix rust-cache 'target' artifact target * Bump something to trigger workflow * Fix the typo I added to trigger a workflow * Update toolchain. --------- Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds Docker image caching to our GHA workflows
Which issue(s) this PR fixes:
Fixes #155