Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_primary_ip function to imix. #158

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 16, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Enables Imix to determine it's own IP address in anticipation of graphql API changes.

Which issue(s) this PR fixes:

Fixes #149

@hulto hulto linked an issue Mar 16, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@292de05). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f916370 differs from pull request most recent head c0a8650. Consider uploading reports for the commit c0a8650 to get more accurate results

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage        ?   56.17%           
=======================================
  Files           ?       28           
  Lines           ?     1376           
  Branches        ?        0           
=======================================
  Hits            ?      773           
  Misses          ?      522           
  Partials        ?       81           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to ensure this doesn't break if ipv4 is an empty array, but accepting to unblock.

implants/imix/src/main.rs Outdated Show resolved Hide resolved
implants/imix/src/main.rs Show resolved Hide resolved
@hulto hulto merged commit e3a5b2d into main Mar 23, 2023
@hulto hulto deleted the 149-feature-imix-primary-ip-resolution branch March 23, 2023 02:11
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add get_primary_ip function to imix. (#158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive Primary IP Address
2 participants