Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

131 bug report output on error #183

Merged
merged 32 commits into from
May 4, 2023
Merged

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Apr 8, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@hulto hulto linked an issue Apr 8, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #183 (9616fc1) into main (8f2cc3d) will increase coverage by 2.78%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   69.12%   71.91%   +2.78%     
==========================================
  Files          75       75              
  Lines        3803     3959     +156     
==========================================
+ Hits         2629     2847     +218     
+ Misses       1089     1027      -62     
  Partials       85       85              
Impacted Files Coverage Δ
implants/imix/src/graphql.rs 94.54% <66.66%> (+0.03%) ⬆️
implants/eldritch/src/lib.rs 90.81% <80.95%> (-3.15%) ⬇️
implants/imix/src/main.rs 67.86% <88.23%> (+38.97%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto
Copy link
Collaborator Author

hulto commented Apr 9, 2023

This PR relies on #177

@hulto
Copy link
Collaborator Author

hulto commented Apr 9, 2023

Adds a main loop test to make sure the agent can get, execute, and report output.
image

@hulto hulto marked this pull request as ready for review April 12, 2023 15:47
@Cictrone Cictrone merged commit ec773a2 into main May 4, 2023
@Cictrone Cictrone deleted the 131-bug-report-output-on-error branch May 4, 2023 00:07
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
131 bug report output on error (#183)

* Updated starlark to latest commit.

* Update golem starlark version.

* Refactor eval stuff.

* Actually update to latest.

* alloc_list was removed from starlark.

* Added new allocative crate.

* Updated rust version to match starlark.

* Nothing works abandoning

* pause

* Update eldritch starlark version.

* Updating eval from starlark.

* Updated sysinfo to reslove ntapi error

* Updated list impl for new sysinfo crate

* Update process list to new sysinfo version

* Removed uneeded feature.

* Custom printhandler works but can't pass attributes

* Implement custom print handler with async channels

* Have golem print to stdout not stderr.

* First pass at async print handlers in imix.

* Don't need to import starlark.

* Everything compiles need to do integration testing

* Update schema

* poc of channel read write.

* Seems to work.

* exec_task struct instead of tuple.

* Better name.

* Add main loop test.

* Added main loop test

* Clean up warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Report output on error
2 participants