-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
131 bug report output on error #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 69.12% 71.91% +2.78%
==========================================
Files 75 75
Lines 3803 3959 +156
==========================================
+ Hits 2629 2847 +218
+ Misses 1089 1027 -62
Partials 85 85
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR relies on #177 |
Cictrone
approved these changes
May 4, 2023
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
131 bug report output on error (#183) * Updated starlark to latest commit. * Update golem starlark version. * Refactor eval stuff. * Actually update to latest. * alloc_list was removed from starlark. * Added new allocative crate. * Updated rust version to match starlark. * Nothing works abandoning * pause * Update eldritch starlark version. * Updating eval from starlark. * Updated sysinfo to reslove ntapi error * Updated list impl for new sysinfo crate * Update process list to new sysinfo version * Removed uneeded feature. * Custom printhandler works but can't pass attributes * Implement custom print handler with async channels * Have golem print to stdout not stderr. * First pass at async print handlers in imix. * Don't need to import starlark. * Everything compiles need to do integration testing * Update schema * poc of channel read write. * Seems to work. * exec_task struct instead of tuple. * Better name. * Add main loop test. * Added main loop test * Clean up warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #