Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dict return type and updated test. #184

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Apr 9, 2023

What type of PR is this?

/kind cleanup
/kind eldritch-function

What this PR does / why we need it:

This PR allows users to more easily interact with the output from process.list() Eg:

image

#### Which issue(s) this PR fixes: Fixes #181

@hulto hulto added cleanup Code cleanup and tech debt removal eldritch Related to the Eldritch language labels Apr 9, 2023
@hulto hulto linked an issue Apr 9, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #184 (1f04e18) into main (26ea94f) will decrease coverage by 0.10%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   73.11%   73.01%   -0.10%     
==========================================
  Files          78       78              
  Lines        4247     4243       -4     
==========================================
- Hits         3105     3098       -7     
- Misses       1057     1060       +3     
  Partials       85       85              
Impacted Files Coverage Δ
implants/eldritch/src/process/list_impl.rs 86.15% <89.28%> (-5.16%) ⬇️
implants/eldritch/src/process.rs 38.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUT pls resolve

implants/eldritch/src/process/list_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/process/list_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/process/list_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/process/list_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/process/list_impl.rs Outdated Show resolved Hide resolved
@hulto hulto merged commit 995d1be into main May 6, 2023
@hulto hulto deleted the 181-implement-process-list-results-as-a-vector-of-dicts-similar-to-port-scan branch May 6, 2023 00:14
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add dict return type and updated test. (#184)

* Add dict return type and updated test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup and tech debt removal eldritch Related to the Eldritch language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement process list results as a vector of Dicts similar to port scan
2 participants