Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eldritch File.Read #20

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Eldritch File.Read #20

merged 4 commits into from
Apr 2, 2022

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 15, 2022

What type of PR is this?

What this PR does / why we need it:

This PR will add file read to the eldritch language.

@hulto hulto requested a review from Cictrone March 15, 2022 01:42
@hulto hulto changed the title Implementation done. Working on testing error codes. Eldritch File.Read Mar 17, 2022
Copy link
Collaborator

@Milkshak3s Milkshak3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

fn test_read_nonexistent() -> anyhow::Result<()> {
// Create file
let tmp_file = NamedTempFile::new()?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These delete on drop, guess I didn't need that cleanup step in my own tests!

@hulto hulto closed this Apr 2, 2022
@hulto
Copy link
Collaborator Author

hulto commented Apr 2, 2022

Trying to fix github docs action hanging.

@hulto hulto reopened this Apr 2, 2022
@hulto hulto merged commit 698e6c3 into main Apr 2, 2022
@hulto hulto deleted the hulto-eldritch-feature-file-read branch April 2, 2022 03:34
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Eldritch File.Read (#20)

Eldritch File.Read method implemented, documented, and tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants