Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement file.mkdir #252

Merged
merged 5 commits into from
Jul 29, 2023
Merged

implement file.mkdir #252

merged 5 commits into from
Jul 29, 2023

Conversation

1nv8rzim
Copy link
Collaborator

@1nv8rzim 1nv8rzim commented Jul 26, 2023

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

This PR implements file.mkdir

Which issue(s) this PR fixes:

Fixes #13

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #252 (4475c73) into main (64e5dad) will increase coverage by 0.15%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   74.90%   75.06%   +0.15%     
==========================================
  Files          87       87              
  Lines        5273     5302      +29     
==========================================
+ Hits         3950     3980      +30     
+ Misses       1237     1236       -1     
  Partials       86       86              
Files Changed Coverage Δ
implants/lib/eldritch/src/file/mkdir_impl.rs 96.77% <96.77%> (+96.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs.
LGTM 🚀

@1nv8rzim 1nv8rzim merged commit 1ff14a9 into spellshift:main Jul 29, 2023
8 checks passed
@1nv8rzim 1nv8rzim deleted the 13-implement-file.mkdir branch July 29, 2023 01:06
hulto pushed a commit that referenced this pull request Sep 30, 2023
* implement file.mkdir

* remove extra remove_dir

* documentation of file.mkdir

* Adding error cases to documentation

---------

Co-authored-by: 1nv8rZim <msf9542@rit.edu>
hulto pushed a commit that referenced this pull request Sep 30, 2023
* implement file.mkdir

* remove extra remove_dir

* documentation of file.mkdir

* Adding error cases to documentation

---------

Co-authored-by: 1nv8rZim <msf9542@rit.edu>
hulto pushed a commit that referenced this pull request Oct 5, 2023
* implement file.mkdir

* remove extra remove_dir

* documentation of file.mkdir

* Adding error cases to documentation

---------

Co-authored-by: 1nv8rZim <msf9542@rit.edu>
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
implement file.mkdir (#252)

* implement file.mkdir

* remove extra remove_dir

* documentation of file.mkdir

* Adding error cases to documentation

---------

Co-authored-by: 1nv8rZim <msf9542@rit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement file.mkdir
2 participants