Crypto Module #276
Merged
Crypto Module #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulto
reviewed
Aug 15, 2023
hulto
reviewed
Aug 15, 2023
| let f = File::open(src)?; | ||
| let mut reader = BufReader::new(f); | ||
| let mut buffer: Vec<u8> = Vec::new(); | ||
| reader.read_to_end(&mut buffer)?; |
There was a problem hiding this comment.
We may want to switch to a streaming encryption for better performance with large files.
I've seen a few c2s crash trying to encrypt Medium to large files especially on low powered VMs in competitions.
hulto
reviewed
Aug 15, 2023
hulto
approved these changes
Aug 15, 2023
hulto
reviewed
Sep 6, 2023
| The <b>crypto.aes_encrypt_file</b> method encrypts and decrypts the given src file, encrypts it using the given key, and writes it to disk at the dst location. | ||
|
|
||
| This uses the AES CTR algorithm, and the key parameter will be used for the key and IV. | ||
|
|
There was a problem hiding this comment.
Please add the docs for aes_decrypt_file
hulto
reviewed
Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 71.91% 74.75% +2.84%
==========================================
Files 90 94 +4
Lines 5739 6088 +349
==========================================
+ Hits 4127 4551 +424
+ Misses 1526 1451 -75
Partials 86 86
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Testing memory consumption
|
|
Seems like 16 bytes might be getting truncated on large (1GB) files. Could be because the files are all 0s. |
|
|
|
Found what was causing last 2 bytes to get cut. Pushing fix soon. |
|
LGTM 🏎️ |
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
* Add Grounds for Crypto * Add crypto docs * Implement crypto.aes_encrypt_file() and crypto.hash_file() * Fix Newlines * Fix Tests for AES Encrypt * Debug * Everything Works Now * Allow Support for Encrpyting File in Place * It Needed a Check for Destination File Existing * Remove Redundant File Creation * Fix Perfect Block Size Files * Docs and Tests * Windows Fix
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
* Add Grounds for Crypto * Add crypto docs * Implement crypto.aes_encrypt_file() and crypto.hash_file() * Fix Newlines * Fix Tests for AES Encrypt * Debug * Everything Works Now * Allow Support for Encrpyting File in Place * It Needed a Check for Destination File Existing * Remove Redundant File Creation * Fix Perfect Block Size Files * Docs and Tests * Windows Fix
hulto
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Add Grounds for Crypto * Add crypto docs * Implement crypto.aes_encrypt_file() and crypto.hash_file() * Fix Newlines * Fix Tests for AES Encrypt * Debug * Everything Works Now * Allow Support for Encrpyting File in Place * It Needed a Check for Destination File Existing * Remove Redundant File Creation * Fix Perfect Block Size Files * Docs and Tests * Windows Fix
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Crypto Module (#276) * Add Grounds for Crypto * Add crypto docs * Implement crypto.aes_encrypt_file() and crypto.hash_file() * Fix Newlines * Fix Tests for AES Encrypt * Debug * Everything Works Now * Allow Support for Encrpyting File in Place * It Needed a Check for Destination File Existing * Remove Redundant File Creation * Fix Perfect Block Size Files * Docs and Tests * Windows Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
/kind feature
/kind api-change
/kind eldritch-function
What this PR does / why we need it:
Adds the crypto module with methods to encrypt and hash files.
Starts framework for future cryptography-based methods.
Which issue(s) this PR fixes:
Fixes #67
Fixes #68
Fixes #275