-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample tomes #315
Merged
Merged
Add sample tomes #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-sample-tomes
…into add-sample-tomes
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 75.17% 75.17%
=======================================
Files 100 100
Lines 6591 6591
=======================================
Hits 4955 4955
Misses 1549 1549
Partials 87 87 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cictrone
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls fix b4 merge
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Add sample tomes (#315) * Added a few tomes. * Added a few tomes. * Added proc and file list * Added ifconfig * Update paramdefs key * Updated tome metadata with labels and placholders. * Handle kthread issue. * Add string to list convesion * Cast timeout to int * Added a few tomes. * Added a few tomes. * Added proc and file list * Added ifconfig * Update paramdefs key * Updated tome metadata with labels and placholders. * Handle kthread issue. * Add string to list convesion * Cast timeout to int * Switch to write template and download exec. * Remove debug * Remove hello_world * Remove files - this is broken rn. * add embedded file dir * Updated test assertions. * Fix example tome test. * Document * arg * Triple quote pretty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR adds some default tomes:
Which issue(s) this PR fixes: