Persist imix output through connection failuers #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 74.57% 74.63% +0.05%
==========================================
Files 96 96
Lines 6380 6402 +22
==========================================
+ Hits 4758 4778 +20
- Misses 1535 1537 +2
Partials 87 87
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jabbate19
requested changes
Oct 16, 2023
implants/imix/src/main.rs
Outdated
Comment on lines
396
to
399
| if loop_count_max.is_some() { | ||
| loop_count += 1; | ||
| if (loop_count >= loop_count_max.context("loop_count_max shouldn't be None")?) { return Ok(()); }; | ||
| } |
There was a problem hiding this comment.
I think this can get rewritten using if let
if let Some(count_max) = loop_count_max {
loop_count += 1;
if loop_count >= count_max {
return Ok(())
}
} else {
// Handle it being None
}
There was a problem hiding this comment.
Oooh that is cleaner 🙌
hulto
deleted the
305-imix-reporting-doesnt-hold-output-until-it-reconnects
branch
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #305