Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding #329

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Encoding #329

merged 7 commits into from
Oct 16, 2023

Conversation

jabbate19
Copy link
Collaborator

What type of PR is this?

/kind documentation
/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds the following methods:

  • encode_b64
  • decode_b64
  • from_json
  • to_json

Which issue(s) this PR fixes:

Fixes #146

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple thoughts

implants/lib/eldritch/src/crypto/decode_b64_impl.rs Outdated Show resolved Hide resolved
implants/lib/eldritch/src/crypto/encode_b64_impl.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #329 (0d06935) into main (c88eb67) will increase coverage by 0.43%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   74.63%   75.06%   +0.43%     
==========================================
  Files          96      100       +4     
  Lines        6402     6545     +143     
==========================================
+ Hits         4778     4913     +135     
- Misses       1537     1545       +8     
  Partials       87       87              
Files Coverage Δ
...mplants/lib/eldritch/src/crypto/decode_b64_impl.rs 100.00% <100.00%> (ø)
...mplants/lib/eldritch/src/crypto/encode_b64_impl.rs 100.00% <100.00%> (ø)
implants/lib/eldritch/src/crypto/from_json_impl.rs 100.00% <100.00%> (ø)
implants/lib/eldritch/src/crypto/to_json_impl.rs 100.00% <100.00%> (ø)
implants/lib/eldritch/src/lib.rs 92.75% <100.00%> (ø)
implants/lib/eldritch/src/crypto.rs 41.81% <50.00%> (+3.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed docs

docs/_docs/user-guide/eldritch.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/eldritch.md Show resolved Hide resolved
@jabbate19 jabbate19 requested a review from hulto October 16, 2023 19:14
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One documentation thing approving to unblock though 🙌 stellar features 🔥

docs/_docs/user-guide/eldritch.md Outdated Show resolved Hide resolved
@jabbate19 jabbate19 merged commit 68de0f4 into main Oct 16, 2023
8 checks passed
@jabbate19 jabbate19 deleted the encoding branch October 16, 2023 19:36
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Encoding (#329)

* Add Encoding Functions

* Docs

* Add default

* Tests for JSON

* Update JSON doc

* Indiciate Default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement common encoding methods
2 participants