-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoding #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple thoughts
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 74.63% 75.06% +0.43%
==========================================
Files 96 100 +4
Lines 6402 6545 +143
==========================================
+ Hits 4778 4913 +135
- Misses 1537 1545 +8
Partials 87 87
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One documentation thing approving to unblock though 🙌 stellar features 🔥
What type of PR is this?
/kind documentation
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Adds the following methods:
Which issue(s) this PR fixes:
Fixes #146