Add http file download functionality #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing in GH but I can't see why. Documented in #37 |
Probably a billing issue have to wait for the new month for CI to start working. |
|
Please add a description to: |
…ealm into milkshak3s-eld-file-download
moved from _dst _uri -> dst uri to keep in line with used var naming scheme.
hulto
requested changes
Apr 2, 2022
docs/_docs/user-guide/eldritch.md
Outdated
| @@ -27,7 +27,7 @@ The <b>file.copy</b> copies a file from src path to dst path. If dst path doesn' | |||
| ### file.download | |||
| `file.download(uri: str, dst: str) -> None` | |||
|
|
|||
| The <b>file.download</b> method is very cool, and will be even cooler when Nick documents it. | |||
| The <b>file.download</b> method downloads a file at the URI specified in `uri` to the path specified in `dst`. This currently only supports `http` & `https` protocols. | |||
There was a problem hiding this comment.
Please add a description of what will happen if the dst file already exists.
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Add http file download functionality (#33) * Add http file download functionality * Update download_impl.rs * Remove my print testing whoops * Add docs * Updated vars moved from _dst _uri -> dst uri to keep in line with used var naming scheme. * Fixed one more ^ * Updated var naming scheme. * Update eldritch.md Co-authored-by: Hulto <hulto@hul.to>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Implements the
downloadfunction for the implant.This is a solution for #19
/kind feature
What this PR does / why we need it:
Implements the download function for the Eldritch implant
Which issue(s) this PR fixes:
Fixes #19