Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(empty-state): Add empty states for pages #335

Merged
merged 3 commits into from
Oct 29, 2023
Merged

fix(empty-state): Add empty states for pages #335

merged 3 commits into from
Oct 29, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Oct 29, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Added loading states to components
  • Added error states to components
  • Added no data states to components
  • Added 'next step' buttons to empty states

Sketches

Screenshot 2023-10-28 at 8 21 39 PM Screenshot 2023-10-28 at 8 21 05 PM Screenshot 2023-10-28 at 8 19 56 PM Screenshot 2023-10-28 at 8 19 41 PM Screenshot 2023-10-28 at 8 24 24 PM

@cmp5987 cmp5987 requested a review from hulto October 29, 2023 00:14
hulto
hulto approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫥 🚀

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #335 (53e222a) into main (e450895) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files         101      101           
  Lines        6604     6604           
=======================================
  Hits         4966     4966           
  Misses       1551     1551           
  Partials       87       87

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmp5987 cmp5987 merged commit e4963c5 into main Oct 29, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp/un-auth-view branch October 29, 2023 00:42
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987
97d6551 
 
fix(empty-state): Add empty states for pages (#335)

* fix(empty-state): Add empty states for pages

* fix(build): Build for production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmp5987 @hulto