Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tomes and touchups #342

Merged
merged 14 commits into from
Oct 30, 2023
Merged

Add tomes and touchups #342

merged 14 commits into from
Oct 30, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Oct 29, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds download and execute tome.
Fixes sys.exec docs.

Which issue(s) this PR fixes:

Fixes #

Copy link
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watched Demo of new tome

LGTM

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #342 (3c27d19) into main (753bd6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files         103      103           
  Lines        6732     6732           
=======================================
  Hits         5075     5075           
  Misses       1570     1570           
  Partials       87       87           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto hulto merged commit fc5d8fe into main Oct 30, 2023
8 checks passed
@hulto hulto deleted the add-tomes-and-touchups branch October 30, 2023 00:45
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add tomes and touchups (#342)

* Windows tested

* execute -> exec

* Implement download and execute tome.

* Update to disown properly.

* Update label

* Don't query first get example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants