Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executable url param. #347

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add executable url param. #347

merged 2 commits into from
Nov 2, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Nov 2, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Adds the missing executable_url param to the service persit tome

Which issue(s) this PR fixes:

@hulto hulto requested a review from jabbate19 November 2, 2023 23:43
Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #347 (3f9172e) into main (bf75ac9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files         103      103           
  Lines        6736     6736           
=======================================
  Hits         5086     5086           
  Misses       1563     1563           
  Partials       87       87           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto hulto merged commit 8061719 into main Nov 2, 2023
8 checks passed
@hulto hulto deleted the fix-service-persit-tome branch November 2, 2023 23:55
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add executable url param. (#347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants