-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sys.write_reg() function to eldritch #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple changes.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 71.13% 71.95% +0.82%
==========================================
Files 109 112 +3
Lines 8089 8729 +640
==========================================
+ Hits 5754 6281 +527
- Misses 2226 2339 +113
Partials 109 109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good.
Few changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
One note on docs but after that ship it! 🫡
add sys.write_reg() function to eldritch (#387) * add reg_write function * clean test function and add docs for write_reg * implement write_reg function * write_reg accepts different registry types * adding more examples for sys.write_reg() * fix errors from merge conflicts * add missing import in get_reg * cleanup and made recommended changes * fix eldritch docs * adding write_reg_str, write_reg_int and write_reg_hex functions * fix missing exposed functions in lib.rs * split write_reg functions into multiple pages * change funcs to alphabetical order * clean up docs for new functions * fix typo in docs
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Added sys.get_reg() function to eldritch. only installs on windows systems.
$> sys.write_reg("HKEY_CURRENT_USER","SOFTWARE\TEST1","FOO1","REG_SZ","BAR1")
"A new key has been created"
$> sys.write_reg("HKEY_CURRENT_USER","SOFTWARE\TEST1","FOO1","REG_BINARY","DEADBEEF")
"An existing key has been modified"
Which issue(s) this PR fixes:
Fixes #