Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hulto eldritch file append #4

Merged
merged 32 commits into from
Mar 1, 2022
Merged

Hulto eldritch file append #4

merged 32 commits into from
Mar 1, 2022

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 1, 2022

Added append function to eldritch

Cictrone and others added 26 commits February 15, 2022 06:07
@Cictrone
started imix bot
8ea3fae
@Cictrone
added basic reading of config file and a bit of a touch up around args
674a7cd
@Cictrone
wrote the linux install and re-orged some of the namespacing
7fa9be8
@Cictrone
added a ton fo logic for the initial call back, also errors!
7100a29
@Cictrone
changed the String to a PathBuf for newman :^)
00b3964
@Cictrone
project structure?
c9a2041
@Cictrone
RESTRUCTURING
456048b
@Cictrone
gett the initial starlark setup
8dc5c06
@Cictrone
perf issues fixed and working examplegit add .!
1e2534e
@Cictrone
stubbed out the first version of the eldritch stdlib
827e0f9
@Cictrone
rebase!
30ec8e7
@Cictrone
started imix bot
8cd5836
@Cictrone
added basic reading of config file and a bit of a touch up around args
2f75a20
@Cictrone
wrote the linux install and re-orged some of the namespacing
fc7f389
@Cictrone
added a ton fo logic for the initial call back, also errors!
e589c81
@Cictrone
changed the String to a PathBuf for newman :^)
d6610e6
@Cictrone
project structure?
03ed3c9
@Cictrone
RESTRUCTURING
d14698e
@Cictrone
gett the initial starlark setup
46697e9
@Cictrone
perf issues fixed and working examplegit add .!
eec9cc2
@Cictrone
stubbed out the first version of the eldritch stdlib
7d59622
@Cictrone
rebase!
d563bc3
@Cictrone
Merge branch 'nick' of github.com:KCarretto/realm into nick
6f94a9c
@hulto
eldritch append works + testing
d6dca51
@hulto
Merging
4412ed6
@hulto
Remove file after test. Added docs.
d5ef9a0
@KCarretto KCarretto self-assigned this Mar 1, 2022
KCarretto
KCarretto approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, definitely impact that aligns with our North Star without boiling the ocean or leaving anything on the shelf.

@hulto hulto merged commit 9fba88d into main Mar 1, 2022
@KCarretto KCarretto deleted the hulto-eldritch-file-append branch March 7, 2022 19:03
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto @Cictrone
5943875 
 
Hulto eldritch file append (#4)

* eldritch append works + testing

* Remove file after test. Added docs.

* Missed append. Removing test file.

* Added test existing.

* Update README.md

* Removed uneeded match case.

* Update eldritch_nav.yml

Co-authored-by: Nicholas OBrien <ndo9903@rit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KCarretto KCarretto KCarretto approved these changes

Assignees

@KCarretto KCarretto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hulto @KCarretto @Cictrone