file.find()

[jabbate19]

What type of PR is this?

/kind documentation
/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds way to search given directory for file matching criteria.

Please give feedback on current implementation. Imo its kinda rough.

Which issue(s) this PR fixes:

Fixes #66

[codecov]

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (4a19ccd) 71.95% compared to head (e9bed88) 71.39%.

Files	Patch %	Lines
implants/lib/eldritch/src/file/find_impl.rs	0.00%	67 Missing ⚠️
implants/lib/eldritch/src/file.rs	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   71.95%   71.39%   -0.56%     
==========================================
  Files         112      113       +1     
  Lines        8729     8800      +71     
==========================================
+ Hits         6281     6283       +2     
- Misses       2339     2408      +69     
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hulto]

Couple changes

[hulto]

Could be cleaner to switch to a match.

[jabbate19]

Problem is that for unix I'm making calls to a permissions trait in PermissionsExt, so if we don't do this then the Windows version will try and compile with the use of the unix-only trait and error

[hulto]

Couldn't it still be bound in the #[cfg(windows)] ?
I'm thinking

#[cfg(windows)]
{
    match permissions {
        0 => {
            if metadata.readonly() { return Ok(false) }
        }
       1 => {
            if !metadata.readonly() { return Ok(false) }
       }
       _ => {
          return anyhow::anyhow!("Windows only supports readonly (0) or not-readonly (1)")
      }
    }
}

[hulto]

Outside the scope of this PR but in the future is it possible to add newer than or older than?

Seeing this I realized it'll be be rare files match a specific second.

[jabbate19]

Yeah that was what I was curious about with these. Do we want older/newer to be the default action?

[hulto]

If you want to make the changes in this PR i would:

• Remove the modified time and created time fields
• Replace modified time with a modified_before and modified_after option
• Replace created time with a created_before and created_after option

This would make it possible to time bound your search for things created within a specifir and or modified in a specific range.

[hulto]

This looks good to me.
If you want to do the newerthan olderthan I think that would be a great addition but not required.
Nit on match case but NBD if you don't do it.

[hulto]

Works for me.