Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cp quest view fixup #437

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Cp quest view fixup #437

merged 3 commits into from
Jan 16, 2024

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Jan 16, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Add search bar to quest view
  • Add users to quest view
  • Add tome name to quest details

Screenshots

Screenshot 2024-01-15 at 7 34 15 PM

@cmp5987 cmp5987 requested a review from hulto January 16, 2024 00:34
hulto
hulto approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@cmp5987 cmp5987 merged commit 7466ed1 into main Jan 16, 2024
6 checks passed
@cmp5987 cmp5987 deleted the cp-quest-view-fixup branch January 16, 2024 01:05
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987 @hulto
0c1feba 
 
Cp quest view fixup (#437)

* feature(quest): Add searching to quest view and change layout

* fix(build): Build UI

---------

Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmp5987 @hulto