Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding file tree tome and update bad reference in docs #438

Merged
merged 3 commits into from
Jan 16, 2024
Merged

adding file tree tome and update bad reference in docs #438

merged 3 commits into from
Jan 16, 2024

Conversation

adm1nPanda
Copy link
Collaborator

What type of PR is this?

/feature
/kind tomes

What this PR does / why we need it:

Adding file tree tome

Which issue(s) this PR fixes:

Fixes #422

@adm1nPanda adm1nPanda requested a review from hulto January 16, 2024 03:05
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c099f3) 73.47% compared to head (86a8a17) 71.46%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   73.47%   71.46%   -2.02%     
==========================================
  Files          85      115      +30     
  Lines        7006     8835    +1829     
==========================================
+ Hits         5148     6314    +1166     
- Misses       1858     2412     +554     
- Partials        0      109     +109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hulto
hulto previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adm1nPanda adm1nPanda requested a review from hulto January 16, 2024 22:07
hulto
hulto approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding links LGTM

@adm1nPanda adm1nPanda merged commit 6c77394 into main Jan 16, 2024
7 of 8 checks passed
@adm1nPanda adm1nPanda deleted the file_tree_tome branch January 16, 2024 22:20
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@adm1nPanda
27f16e0 
 
adding file tree tome and update bad reference in docs (#438)

* adding file tree tome and update bad reference in docs

* including links in tree and fix missing type for links in file_list tome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a file tree tome.
2 participants
@adm1nPanda @hulto