Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra newline from standard print handler. #444

Merged
merged 9 commits into from
Jan 21, 2024

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jan 19, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes an issue where golem and imix had different newline prints.

Which issue(s) this PR fixes:

Fixes #440

@hulto hulto linked an issue Jan 19, 2024 that may be closed by this pull request
Remove debug.
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d20d60) 71.53% compared to head (93a05d2) 71.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   71.53%   71.53%           
=======================================
  Files         118      118           
  Lines        9006     9006           
=======================================
  Hits         6442     6442           
  Misses       2441     2441           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto merged commit feb4640 into main Jan 21, 2024
8 checks passed
@hulto hulto deleted the 440-bug-imix-and-golem-prints-are-inconsistent branch January 21, 2024 20:23
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
remove extra newline from standard print handler. (#444)

* remove extra newline from standard print handler.

* Update main.eldritch

Remove debug.

* Update lib.rs

Undo attempt at fstrings.

* Update lib.rs

Fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] imix and golem prints are inconsistent
2 participants