Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Enable Beacon assertions in Tests #449

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Conversation

KCarretto
Copy link
Collaborator

@KCarretto KCarretto commented Jan 21, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates tests to assert ClaimTasks updates Beacon ents.

Which issue(s) this PR fixes:

Fixes #373

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e59b69b) 71.46% compared to head (667b141) 71.46%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files         118      118           
  Lines        9003     9003           
=======================================
  Hits         6434     6434           
  Misses       2446     2446           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KCarretto KCarretto changed the title [feature] Added next_seen_at field, updated tests [cleanup] Enable Beacon assertions in Tests Jan 21, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We love some testing 😎

@KCarretto KCarretto merged commit 93cfbf4 into main Jan 21, 2024
6 checks passed
@KCarretto KCarretto deleted the beacon-next-seen-at branch January 21, 2024 18:37
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
[cleanup] Enable Beacon assertions in Tests (#449)

* Added next_seen_at field, updated tests

* remove next_seen_at since it's unwanted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dead flag to the beacons field
2 participants